All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 1/5] ASoC: fsl_ssi: Make error message concise
Date: Wed, 7 Jan 2015 10:43:20 -0800	[thread overview]
Message-ID: <20150107184319.GA2576@Asurada> (raw)
In-Reply-To: <1420645476-13193-1-git-send-email-festevam@gmail.com>

On Wed, Jan 07, 2015 at 01:44:32PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Currently the error message uses 'np->full_name' which leads to a very verbose
> log as:
> 
> fsl-ssi-dai 202c000.ssi: no irq for node /soc/aips-bus@02000000/spba-bus@02000000/ssi@0202c000
> 
> We can have a concise log by using pdev->name instead:
> 
> fsl-ssi-dai 202c000.ssi: no irq for node 202c000.ssi
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

For all these 5 patches,

Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>

Thank you
Nicolin

> ---
>  sound/soc/fsl/fsl_ssi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index a65f17d..fa19507 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -1363,7 +1363,7 @@ static int fsl_ssi_probe(struct platform_device *pdev)
>  
>  	ssi_private->irq = platform_get_irq(pdev, 0);
>  	if (!ssi_private->irq) {
> -		dev_err(&pdev->dev, "no irq for node %s\n", np->full_name);
> +		dev_err(&pdev->dev, "no irq for node %s\n", pdev->name);
>  		return -ENXIO;
>  	}
>  
> -- 
> 1.9.1
> 

  parent reply	other threads:[~2015-01-07 18:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 15:44 [PATCH 1/5] ASoC: fsl_ssi: Make error message concise Fabio Estevam
2015-01-07 15:44 ` [PATCH 2/5] ASoC: fsl_asrc: " Fabio Estevam
2015-01-07 15:44 ` [PATCH 3/5] ASoC: fsl_sai: " Fabio Estevam
2015-01-07 15:44 ` [PATCH 4/5] ASoC: fsl_esai: " Fabio Estevam
2015-01-07 15:44 ` [PATCH 5/5] ASoC: fsl_spdif: " Fabio Estevam
2015-01-07 18:43 ` Nicolin Chen [this message]
2015-01-08 18:35 ` [PATCH 1/5] ASoC: fsl_ssi: " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150107184319.GA2576@Asurada \
    --to=nicoleotsuka@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.