From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] qt5cinex: Add new Qt5CinematicExperience package.
Date: Wed, 7 Jan 2015 21:39:40 +0100 [thread overview]
Message-ID: <20150107213940.40b78504@free-electrons.com> (raw)
In-Reply-To: <1420640541-29637-1-git-send-email-pierre.lemagourou@openwide.fr>
Hello,
On Wed, 7 Jan 2015 15:22:21 +0100, pierre.lemagourou at openwide.fr wrote:
> From: Pierre Le Magourou <pierre.lemagourou@openwide.fr>
>
> Signed-off-by: Pierre Le Magourou <pierre.lemagourou@openwide.fr>
Thanks, applied, after doing a number of additional changes:
[Thomas:
- Change the dependency logic in the Config.in file. We don't want to
have a 'depends on BR2_PACKAGE_QT5GRAPHICALEFFECTS': it should be
selected automatically. Instead, let's have a dependency on Qt5 and
OpenGL, and select everything else automatically. A comment is
added, shown only when Qt5 is available, on the right platforms
(which have JSCore support), to explain that we need an OpenGL
backend.
- Change the prompt of the package to be qt5cinex, to match the
package name.
- Replace "High-definition support" by "High-definition version".
- Fix a typo in the Config.in help text: definifition -> definition.
- Add a comment in the .mk file explaining why we install a wrapper
shell script (explanation taken from Pierre's e-mail).
- Fix indentation in the install target commands.
- Keep only sha256 hashes, those are sufficient. Replace the comment
in the hash file by the more traditional "Locally computed".]
If you could test the latest Buildroot master (which has your patch
applied) and check that everything works fine, it would be great.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-01-07 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 14:22 [Buildroot] [PATCH 1/1] qt5cinex: Add new Qt5CinematicExperience package pierre.lemagourou at openwide.fr
2015-01-07 20:39 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 10:05 pierre.lemagourou at openwide.fr
2014-12-14 23:02 ` Yann E. MORIN
2014-12-17 9:37 ` Pierre Le Magourou
2014-12-17 18:12 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150107213940.40b78504@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.