From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: gadget: pxa25x_udc: fix use-before-initialized bug
Date: Thu, 8 Jan 2015 00:31:41 +0100 [thread overview]
Message-ID: <201501080031.41107.marex@denx.de> (raw)
In-Reply-To: <1420655032-14097-1-git-send-email-Nable.MainInbox@googlemail.com>
On Wednesday, January 07, 2015 at 07:23:52 PM, Nable wrote:
> Fix use-before-initialized bug in pxa25x_udc driver.
>
> Function usb_gadget_register_driver calls udc_disable,
> and udc_disable calls pullup_off that uses dev->mach->udc_command.
> But dev->mach is initialized in usb_gadget_register_driver after
> calling udc_disable. This patch fixes the order of initialization.
>
> Signed-off-by: Nable <Nable.MainInbox@googlemail.com>
Hi!
Can you please fix From: and Signed-off-by: fields so that they reflect a real
person (you) ? Otherwise I'm happy you sent the fix and I'll pick the fixed
version.
Thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-01-07 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 18:23 [U-Boot] [PATCH] usb: gadget: pxa25x_udc: fix use-before-initialized bug Nable
2015-01-07 23:31 ` Marek Vasut [this message]
2015-01-08 8:38 ` Nable
2015-01-08 17:05 ` Marek Vasut
2015-01-08 18:19 ` Nable
2015-01-09 0:49 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201501080031.41107.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.