From: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
To: Shuah Khan <shuahkhan@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Matthias Schwarzott <zzam@gentoo.org>,
Antti Palosaari <crope@iki.fi>,
Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCHv3 03/20] cx231xx: add media controller support
Date: Thu, 8 Jan 2015 01:15:27 -0200 [thread overview]
Message-ID: <20150108011527.7fe81beb@concha.lan> (raw)
In-Reply-To: <CAKocOOO7CFkEYKJs3YpyX7gvWv8NMLhwdzF1tv-P+-rc8jxrFA@mail.gmail.com>
Hi Shuah,
Em Wed, 7 Jan 2015 18:44:26 -0700
Shuah Khan <shuahkhan@gmail.com> escreveu:
> > +
> > /* Create v4l2 device */
> > + dev->v4l2_dev.mdev = dev->media_dev;
>
> When media_device_register(mdev) fails in cx231xx_media_device_register(),
> media_dev is null? The above will simply assign null to dev->v4l2_dev.mdev
> Is that correct?
Yes, this is intentional. If the media controls fail to register, everything
will keep working, except for the media controller itself. That sounds better,
IMHO, than to have a complete failure.
Cheers,
Mauro
next prev parent reply other threads:[~2015-01-08 3:15 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 21:08 [PATCHv3 00/20] dvb core: add basic support for the media controller Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 01/20] media: add new types for DVB devnodes Mauro Carvalho Chehab
[not found] ` <7f1ea82b1055aa490726f3af2ad22bca25e49a28.1420578087.git.mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2015-01-07 14:09 ` Sakari Ailus
2015-01-07 14:09 ` Sakari Ailus
[not found] ` <54AD3E00.5070208-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-01-07 14:22 ` Mauro Carvalho Chehab
2015-01-07 14:22 ` Mauro Carvalho Chehab
[not found] ` <20150107122239.232d1f56-iErKd7e5oVp+urZeOPWqwQ@public.gmane.org>
2015-01-08 16:10 ` Laurent Pinchart
2015-01-08 16:10 ` Laurent Pinchart
2015-01-08 17:44 ` Mauro Carvalho Chehab
2015-01-08 17:44 ` Mauro Carvalho Chehab
[not found] ` <20150108154450.654d04d6-iErKd7e5oVp+urZeOPWqwQ@public.gmane.org>
2015-01-11 13:54 ` Laurent Pinchart
2015-01-11 13:54 ` Laurent Pinchart
2015-01-11 14:09 ` Mauro Carvalho Chehab
2015-01-11 14:09 ` Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 02/20] dvbdev: add support for media controller Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 03/20] cx231xx: add media controller support Mauro Carvalho Chehab
2015-01-08 1:44 ` Shuah Khan
2015-01-08 3:15 ` Mauro Carvalho Chehab [this message]
2015-01-06 21:08 ` [PATCHv3 04/20] dvb_frontend: add media controller support for DVB frontend Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 05/20] dmxdev: add support for demux/dvr nodes at media controller Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 06/20] dvb_ca_en50221: add support for CA node at the " Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 07/20] dvb_net: add support for DVB net " Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 08/20] dvbdev: add pad for the DVB devnodes Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 09/20] tuner-core: properly initialize media controller subdev Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 10/20] cx25840: fill the media controller entity Mauro Carvalho Chehab
2015-01-07 11:44 ` Prabhakar Lad
2015-01-07 12:14 ` Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 11/20] cx231xx: initialize video/vbi pads Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 12/20] cx231xx: create media links for analog mode Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 13/20] dvbdev: represent frontend with two pads Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 14/20] dvbdev: add a function to create DVB media graph Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 15/20] cx231xx: create DVB graph Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 16/20] dvbdev: enable DVB-specific links Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 17/20] dvb-frontend: enable tuner link when the FE thread starts Mauro Carvalho Chehab
2015-01-08 21:11 ` Shuah Khan
2015-01-06 21:08 ` [PATCHv3 18/20] cx231xx: enable tuner->decoder link at videobuf start Mauro Carvalho Chehab
2015-01-08 21:15 ` Shuah Khan
2015-01-06 21:08 ` [PATCHv3 19/20] cx231xx: create a streaming pipeline at VB start Mauro Carvalho Chehab
2015-01-06 21:08 ` [PATCHv3 20/20] dvb_frontend: start media pipeline while thread is running Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150108011527.7fe81beb@concha.lan \
--to=mchehab@osg.samsung.com \
--cc=crope@iki.fi \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shuahkhan@gmail.com \
--cc=zzam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.