All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawn.guo@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: davem@davemloft.net, fugang.duan@freescale.com,
	netdev@vger.kernel.org,
	Fabio Estevam <fabio.estevam@freescale.com>
Subject: Re: [PATCH net-next 1/2] Revert "ARM: imx: add FEC sleep mode callback function"
Date: Thu, 8 Jan 2015 20:53:51 +0800	[thread overview]
Message-ID: <20150108125349.GD4928@dragon> (raw)
In-Reply-To: <1420634393-30027-1-git-send-email-festevam@gmail.com>

On Wed, Jan 07, 2015 at 10:39:52AM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> i.MX platform maintainer Shawn Guo is not happy with the such commit as
> explained below [1]:
> 
> "The GPR difference between SoCs can be encoded in device tree as well.
> It's pointless to repeat the same code pattern for every single
> platform, that need to set up GPR bits for enabling magic packet wake
> up, while the only difference is the register and bit offset.
> 
> The platform code will become quite messy and unmaintainable if every
> device driver dump their GPR register setup code into platform.
> 
> Sorry, but it's NACK from me."
> 
> This reverts commit 456062b3ec6f5b9 ("ARM: imx: add FEC sleep mode callback 
> function").
> 
> [1] http://www.spinics.net/lists/netdev/msg310922.html
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Thanks, Fabio.  For both patches,

Acked-by: Shawn Guo <shawn.guo@linaro.org>

  parent reply	other threads:[~2015-01-08 12:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07 12:39 [PATCH net-next 1/2] Revert "ARM: imx: add FEC sleep mode callback function" Fabio Estevam
2015-01-07 12:39 ` [PATCH net-next 2/2] Revert "ARM: dts: imx6qdl: enable FEC magic-packet feature" Fabio Estevam
2015-01-09  4:05   ` David Miller
2015-01-08 12:53 ` Shawn Guo [this message]
2015-01-09  4:05 ` [PATCH net-next 1/2] Revert "ARM: imx: add FEC sleep mode callback function" David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150108125349.GD4928@dragon \
    --to=shawn.guo@linaro.org \
    --cc=davem@davemloft.net \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=fugang.duan@freescale.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.