From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 3/3] mtd: spi-nand: add devicetree binding Date: Thu, 8 Jan 2015 14:35:42 +0000 Message-ID: <20150108143542.GF10537@leverpostej> References: <87F60714EC601C4C83DFF1D2E3D390A04AB425@NTXXIAMBX02.xacn.micron.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <87F60714EC601C4C83DFF1D2E3D390A04AB425-xjs9rfTec9KBtk7LW/CC8tTcztV8WXajQQ4Iyu8u01E@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Pan =?utf-8?B?5r2Y5qCLIChwZXRlcnBhbmRvbmcp?= Cc: "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Pawel Moll , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org" , Brian Norris , Ezequiel Garcia , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Qi Wang =?utf-8?B?546L6LW3IChxaXdhbmcp?= , Frank Liu =?utf-8?B?5YiY576kIChmcmFua2xpdSk=?= , Melanie Zhang =?utf-8?B?5byg54eVIChtZWxhbmllemhhbmcp?= List-Id: devicetree@vger.kernel.org On Thu, Jan 08, 2015 at 12:52:26AM +0000, Peter Pan =E6=BD=98=E6=A0=8B = (peterpandong) wrote: > This commit adds the devicetree binding document that specifies the > spi nand devices support. >=20 > Signed-off-by: Peter Pan > --- > Documentation/devicetree/bindings/mtd/spi-nand.txt | 22 ++++++++++++= ++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.tx= t >=20 > diff --git a/Documentation/devicetree/bindings/mtd/spi-nand.txt b/Doc= umentation/devicetree/bindings/mtd/spi-nand.txt > new file mode 100644 > index 0000000..9dd3efd > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/spi-nand.txt > @@ -0,0 +1,22 @@ > +* NAND driver for MT29F, GD5F and similar SPI NAND flash chips > + > +Required properties: > +- #address-cells, #size-cells : Must be present if the device has su= b-nodes > + representing partitions. Can we refer to the binding document for that? > +- compatible : Should be the manufacturer and the name of the chip. = Bear in mind > + the DT binding is not Linux-only, but in case of Linu= x, see the > + "spi_nand_id_table" array in drivers/mtd/spi-nand/spi= -nand-device.c > + for the list of supported chips. NAK for referring to Linux internals from a binding document. The list of compatible string should be defined in this binding document. > +- reg : Chip-Select number > +- spi-max-frequency : Maximum frequency of the SPI bus the chip can = operate at > + > +Example: > + > + flash: flash@0 { > + #address-cells =3D <1>; > + #size-cells =3D <1>; These aren't necessary as no partitions are defined here. Otherwise, this looks ok. Thanks, Mark. > + compatible =3D "micron,mt29f"; > + reg =3D <0>; > + spi-max-frequency =3D <50000000>; > + }; > + > --=20 > 1.9.1 > N=E5=AB=A5=E5=8F=89=E9=9D=A3=E7=AC=A1y=EE=8C=B7=E6=B0=8Ab=E7=9E=82=EE= =83=91=E5=8D=83v=E8=B1=9D?=E8=97=93{.n?=E5=A3=8F=E6=BC=BD=E9=B4=BEz=E8=B0= =B5z)=E9=9F=B0=E9=AA=85w*=1Fjg=EE=83=8C?=E7=A7=B9=E6=AE=A0=E5=A8=B8=EE=95= =90/=E4=BE=81=E9=8B=A4=E7=BD=90=E6=9E=88?=E5=A8=B9=E6=AB=92=E7=92=80??=E6= =91=BA=E7=8E=9C=E5=9B=A4=7F=EE=92=BF=1E=E7=93=BD=E7=8F=B4=E9=96=94?=E9=8E= =97:+v=E5=A2=BE=E5=A6=9B=E9=91=B6=E4=BD=B6 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754344AbbAHOgn (ORCPT ); Thu, 8 Jan 2015 09:36:43 -0500 Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:64428 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752063AbbAHOgl convert rfc822-to-8bit (ORCPT ); Thu, 8 Jan 2015 09:36:41 -0500 Date: Thu, 8 Jan 2015 14:35:42 +0000 From: Mark Rutland To: Peter Pan =?utf-8?B?5r2Y5qCLIChwZXRlcnBhbmRvbmcp?= Cc: "robh+dt@kernel.org" , Pawel Moll , "ijc+devicetree@hellion.org.uk" , "galak@codeaurora.org" , "dwmw2@infradead.org" , Brian Norris , Ezequiel Garcia , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Qi Wang =?utf-8?B?546L6LW3IChxaXdhbmcp?= , Frank Liu =?utf-8?B?5YiY576kIChmcmFua2xpdSk=?= , Melanie Zhang =?utf-8?B?5byg54eVIChtZWxhbmllemhhbmcp?= Subject: Re: [PATCH 3/3] mtd: spi-nand: add devicetree binding Message-ID: <20150108143542.GF10537@leverpostej> References: <87F60714EC601C4C83DFF1D2E3D390A04AB425@NTXXIAMBX02.xacn.micron.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <87F60714EC601C4C83DFF1D2E3D390A04AB425@NTXXIAMBX02.xacn.micron.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 08, 2015 at 12:52:26AM +0000, Peter Pan 潘栋 (peterpandong) wrote: > This commit adds the devicetree binding document that specifies the > spi nand devices support. > > Signed-off-by: Peter Pan > --- > Documentation/devicetree/bindings/mtd/spi-nand.txt | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/spi-nand.txt > > diff --git a/Documentation/devicetree/bindings/mtd/spi-nand.txt b/Documentation/devicetree/bindings/mtd/spi-nand.txt > new file mode 100644 > index 0000000..9dd3efd > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/spi-nand.txt > @@ -0,0 +1,22 @@ > +* NAND driver for MT29F, GD5F and similar SPI NAND flash chips > + > +Required properties: > +- #address-cells, #size-cells : Must be present if the device has sub-nodes > + representing partitions. Can we refer to the binding document for that? > +- compatible : Should be the manufacturer and the name of the chip. Bear in mind > + the DT binding is not Linux-only, but in case of Linux, see the > + "spi_nand_id_table" array in drivers/mtd/spi-nand/spi-nand-device.c > + for the list of supported chips. NAK for referring to Linux internals from a binding document. The list of compatible string should be defined in this binding document. > +- reg : Chip-Select number > +- spi-max-frequency : Maximum frequency of the SPI bus the chip can operate at > + > +Example: > + > + flash: flash@0 { > + #address-cells = <1>; > + #size-cells = <1>; These aren't necessary as no partitions are defined here. Otherwise, this looks ok. Thanks, Mark. > + compatible = "micron,mt29f"; > + reg = <0>; > + spi-max-frequency = <50000000>; > + }; > + > -- > 1.9.1 > N嫥叉靣笡y氊b瞂千v豝?藓{.n?壏漽鴾z谵z)韰骅w*jg?秹殠娸/侁鋤罐枈?娹櫒璀??摺玜囤瓽珴閔?鎗:+v墾妛鑶佶