From: Tim Deegan <tim@xen.org>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH 3/3] x86/HVM: make hvm_efer_valid() honor guest features
Date: Thu, 8 Jan 2015 16:56:07 +0100 [thread overview]
Message-ID: <20150108155607.GD5043@deinos.phlegethon.org> (raw)
In-Reply-To: <54AEAEFD0200007800052B81@mail.emea.novell.com>
At 15:23 +0000 on 08 Jan (1420727005), Jan Beulich wrote:
> + if ( (value & EFER_LMSLE) && !cpu_has_lmsl )
> + return 0;
I see this bit has no CPUID flag, and the docs don't seem to suggest
that it would ever not be valid. Are there real CPUs where it can't
be set?
My reviewed-by: stands anyway as this is an improvement over the
current code. Just wondering whether this needs to go on the list
of interesting edge cazses for Andrew's feature-levelling rewrite.
Cheers,
Tim.
next prev parent reply other threads:[~2015-01-08 15:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 15:15 [PATCH 0/3] x86: XSA-111 follow-ups Jan Beulich
2015-01-08 15:22 ` [PATCH 1/3] x86: streamline hypercall_create_continuation() Jan Beulich
2015-01-08 16:01 ` Andrew Cooper
2015-01-08 16:11 ` Jan Beulich
2015-01-08 15:22 ` [PATCH 2/3] x86/HVM: clobber hypercall arguments just like for PV Jan Beulich
2015-01-08 17:20 ` Andrew Cooper
2015-01-08 15:23 ` [PATCH 3/3] x86/HVM: make hvm_efer_valid() honor guest features Jan Beulich
2015-01-08 15:56 ` Tim Deegan [this message]
2015-01-08 16:04 ` Jan Beulich
2015-01-08 18:57 ` Andrew Cooper
2015-01-08 18:49 ` Andrew Cooper
2015-01-09 11:20 ` Jan Beulich
2015-01-09 15:09 ` Andrew Cooper
2015-01-09 15:33 ` Jan Beulich
2015-01-09 15:36 ` Andrew Cooper
2015-01-08 15:53 ` [PATCH 0/3] x86: XSA-111 follow-ups Tim Deegan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150108155607.GD5043@deinos.phlegethon.org \
--to=tim@xen.org \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.