All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hadar Hen Zion <hadarh@mellanox.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Amir Vadai <amirv@mellanox.com>,
	Yevgeny Petrilin <yevgenyp@mellanox.com>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	shannon.nelson@intel.com, Doug Ledford <dledford@redhat.com>,
	greearb@candelatech.com
Subject: Re: [RFC net-next 0/3] devconf: New infrastructure for setting pre-load parameters for a module
Date: Thu, 8 Jan 2015 08:46:18 -0800	[thread overview]
Message-ID: <20150108164618.GA11696@kroah.com> (raw)
In-Reply-To: <1420730220-20224-1-git-send-email-hadarh@mellanox.com>

On Thu, Jan 08, 2015 at 05:16:57PM +0200, Hadar Hen Zion wrote:
> Hi,
>     
> When configuring a device at an early boot stage, most kernel drivers
> use module parameters (the parameters' settings can be determined in
> modprobe.d config files).

Which is a bad idea, as you have learned :)

> These parameters are difficult to manage, and one of the reasons is that
> module parameters are set per driver and not per device (NICs using the
> same driver cannot be set with different configurations).
> Furthermore, using other existing configuration tools like ethtool,
> ifconfig, ip link commands or sysfs entries is not applicable, since
> they all rely on having a netdev already set up.
> 
> In the past, 'request_firmware' solution for configuration parameters
> was suggested by Shannon Nelson from Intel[1]. The idea was rejected by
> Greg KH, who claimed it was abusive of the request_firmware mechanism.
> Greg suggested using configfs for device configuration instead (as done
> by the USB gadget driver).
> 
> As a solution, we introduce a new kernel infrastructure using configfs
> to allow the configuration of the device. The goal is to set low-level
> device functionality that needs to be sorted out before a module is
> loaded.

Ick, really?  drivers should never need to be configured like this, if
so, then something is wrong, they should "just work" by default.  What
are you needing to "configure" that can't be determined by something
like a device tree?

greg k-h

  parent reply	other threads:[~2015-01-08 16:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 15:16 [RFC net-next 0/3] devconf: New infrastructure for setting pre-load parameters for a module Hadar Hen Zion
2015-01-08 15:16 ` [RFC net-next 1/3] net/dev_c_mlx4: Support mlx4_core pre-load configuration Hadar Hen Zion
2015-01-08 15:16 ` [RFC net-next 2/3] devconf: Add configuration module for setting pre-load parameters Hadar Hen Zion
2015-01-08 15:17 ` [RFC net-next 3/3] net/mlx4_core: Set port_type value according to configuration module Hadar Hen Zion
2015-01-08 16:46 ` Greg KH [this message]
2015-01-08 17:11   ` [RFC net-next 0/3] devconf: New infrastructure for setting pre-load parameters for a module Amir Vadai
2015-01-08 17:47     ` Greg KH
2015-01-08 19:14       ` Amir Vadai
2015-01-08 19:25         ` Greg KH
2015-01-08 22:28           ` Amir Vadai
2015-01-08 22:32             ` Greg KH
2015-01-12 21:02             ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150108164618.GA11696@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amirv@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=greearb@candelatech.com \
    --cc=hadarh@mellanox.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=shannon.nelson@intel.com \
    --cc=yevgenyp@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.