From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning Date: Fri, 9 Jan 2015 11:16:42 +0000 Message-ID: <20150109111642.GU14516@opensource.wolfsonmicro.com> References: <1420793620-2866-1-git-send-email-voice.shen@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1420793620-2866-1-git-send-email-voice.shen@atmel.com> Sender: linux-kernel-owner@vger.kernel.org To: Bo Shen Cc: Mark Brown , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Fri, Jan 09, 2015 at 04:53:40PM +0800, Bo Shen wrote: > As the commit 5fe5b76 (ASoC: dapm: Do not pretend to support > controls for non mixer/mux widgets) remove the fake control. > > Then, the wm8904 throw out the following warning at runtime. > --->8--- > wm8904 1-001a: Control not supported for path ADCL -> [Left] -> AIFOUTL > wm8904 1-001a: ASoC: no dapm match for ADCL --> Left --> AIFOUTL > wm8904 1-001a: ASoC: Failed to add route ADCL -> Left -> AIFOUTL > wm8904 1-001a: Control not supported for path ADCR -> [Right] -> AIFOUTL > wm8904 1-001a: ASoC: no dapm match for ADCR --> Right --> AIFOUTL > wm8904 1-001a: ASoC: Failed to add route ADCR -> Right -> AIFOUTL > wm8904 1-001a: Control not supported for path ADCL -> [Left] -> AIFOUTR > wm8904 1-001a: ASoC: no dapm match for ADCL --> Left --> AIFOUTR > wm8904 1-001a: ASoC: Failed to add route ADCL -> Left -> AIFOUTR > wm8904 1-001a: Control not supported for path ADCR -> [Right] -> AIFOUTR > wm8904 1-001a: ASoC: no dapm match for ADCR --> Right --> AIFOUTR > wm8904 1-001a: ASoC: Failed to add route ADCR -> Right -> AIFOUTR > wm8904 1-001a: Control not supported for path AIFINR -> [Right] -> DACL > wm8904 1-001a: ASoC: no dapm match for AIFINR --> Right --> DACL > wm8904 1-001a: ASoC: Failed to add route AIFINR -> Right -> DACL > wm8904 1-001a: Control not supported for path AIFINL -> [Left] -> DACL > wm8904 1-001a: ASoC: no dapm match for AIFINL --> Left --> DACL > wm8904 1-001a: ASoC: Failed to add route AIFINL -> Left -> DACL > wm8904 1-001a: Control not supported for path AIFINR -> [Right] -> DACR > wm8904 1-001a: ASoC: no dapm match for AIFINR --> Right --> DACR > wm8904 1-001a: ASoC: Failed to add route AIFINR -> Right -> DACR > wm8904 1-001a: Control not supported for path AIFINL -> [Left] -> DACR > wm8904 1-001a: ASoC: no dapm match for AIFINL --> Left --> DACR > wm8904 1-001a: ASoC: Failed to add route AIFINL -> Left -> DACR > ---8<--- > > This patch is used to remove these warning. > > Signed-off-by: Bo Shen > --- > > sound/soc/codecs/wm8904.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c > index 4d2d2b1..38582d7 100644 > --- a/sound/soc/codecs/wm8904.c > +++ b/sound/soc/codecs/wm8904.c > @@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route adc_intercon[] = { > { "Right Capture PGA", NULL, "Right Capture Mux" }, > { "Right Capture PGA", NULL, "Right Capture Inverting Mux" }, > > - { "AIFOUTL", "Left", "ADCL" }, > - { "AIFOUTL", "Right", "ADCR" }, > - { "AIFOUTR", "Left", "ADCL" }, > - { "AIFOUTR", "Right", "ADCR" }, > + { "AIFOUTL", NULL, "ADCL" }, > + { "AIFOUTL", NULL, "ADCR" }, > + { "AIFOUTR", NULL, "ADCL" }, > + { "AIFOUTR", NULL, "ADCR" }, Is this the right fix here? I am not super familiar with the driver but it appears to contain an "AIFOUTL Mux" control which is not connected to anything. Looks like maybe this is a mistake the mux is indeded to be included in the path? Feels like we should either remove the control as well or hook it into the path. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Date: Fri, 09 Jan 2015 11:16:42 +0000 Subject: Re: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning Message-Id: <20150109111642.GU14516@opensource.wolfsonmicro.com> List-Id: References: <1420793620-2866-1-git-send-email-voice.shen@atmel.com> In-Reply-To: <1420793620-2866-1-git-send-email-voice.shen@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bo Shen Cc: Mark Brown , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Jan 09, 2015 at 04:53:40PM +0800, Bo Shen wrote: > As the commit 5fe5b76 (ASoC: dapm: Do not pretend to support > controls for non mixer/mux widgets) remove the fake control. > > Then, the wm8904 throw out the following warning at runtime. > --->8--- > wm8904 1-001a: Control not supported for path ADCL -> [Left] -> AIFOUTL > wm8904 1-001a: ASoC: no dapm match for ADCL --> Left --> AIFOUTL > wm8904 1-001a: ASoC: Failed to add route ADCL -> Left -> AIFOUTL > wm8904 1-001a: Control not supported for path ADCR -> [Right] -> AIFOUTL > wm8904 1-001a: ASoC: no dapm match for ADCR --> Right --> AIFOUTL > wm8904 1-001a: ASoC: Failed to add route ADCR -> Right -> AIFOUTL > wm8904 1-001a: Control not supported for path ADCL -> [Left] -> AIFOUTR > wm8904 1-001a: ASoC: no dapm match for ADCL --> Left --> AIFOUTR > wm8904 1-001a: ASoC: Failed to add route ADCL -> Left -> AIFOUTR > wm8904 1-001a: Control not supported for path ADCR -> [Right] -> AIFOUTR > wm8904 1-001a: ASoC: no dapm match for ADCR --> Right --> AIFOUTR > wm8904 1-001a: ASoC: Failed to add route ADCR -> Right -> AIFOUTR > wm8904 1-001a: Control not supported for path AIFINR -> [Right] -> DACL > wm8904 1-001a: ASoC: no dapm match for AIFINR --> Right --> DACL > wm8904 1-001a: ASoC: Failed to add route AIFINR -> Right -> DACL > wm8904 1-001a: Control not supported for path AIFINL -> [Left] -> DACL > wm8904 1-001a: ASoC: no dapm match for AIFINL --> Left --> DACL > wm8904 1-001a: ASoC: Failed to add route AIFINL -> Left -> DACL > wm8904 1-001a: Control not supported for path AIFINR -> [Right] -> DACR > wm8904 1-001a: ASoC: no dapm match for AIFINR --> Right --> DACR > wm8904 1-001a: ASoC: Failed to add route AIFINR -> Right -> DACR > wm8904 1-001a: Control not supported for path AIFINL -> [Left] -> DACR > wm8904 1-001a: ASoC: no dapm match for AIFINL --> Left --> DACR > wm8904 1-001a: ASoC: Failed to add route AIFINL -> Left -> DACR > ---8<--- > > This patch is used to remove these warning. > > Signed-off-by: Bo Shen > --- > > sound/soc/codecs/wm8904.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c > index 4d2d2b1..38582d7 100644 > --- a/sound/soc/codecs/wm8904.c > +++ b/sound/soc/codecs/wm8904.c > @@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route adc_intercon[] = { > { "Right Capture PGA", NULL, "Right Capture Mux" }, > { "Right Capture PGA", NULL, "Right Capture Inverting Mux" }, > > - { "AIFOUTL", "Left", "ADCL" }, > - { "AIFOUTL", "Right", "ADCR" }, > - { "AIFOUTR", "Left", "ADCL" }, > - { "AIFOUTR", "Right", "ADCR" }, > + { "AIFOUTL", NULL, "ADCL" }, > + { "AIFOUTL", NULL, "ADCR" }, > + { "AIFOUTR", NULL, "ADCL" }, > + { "AIFOUTR", NULL, "ADCR" }, Is this the right fix here? I am not super familiar with the driver but it appears to contain an "AIFOUTL Mux" control which is not connected to anything. Looks like maybe this is a mistake the mux is indeded to be included in the path? Feels like we should either remove the control as well or hook it into the path. Thanks, Charles From mboxrd@z Thu Jan 1 00:00:00 1970 From: ckeepax@opensource.wolfsonmicro.com (Charles Keepax) Date: Fri, 9 Jan 2015 11:16:42 +0000 Subject: [alsa-devel] [PATCH] ASoC: wm8904: fix runtime warning In-Reply-To: <1420793620-2866-1-git-send-email-voice.shen@atmel.com> References: <1420793620-2866-1-git-send-email-voice.shen@atmel.com> Message-ID: <20150109111642.GU14516@opensource.wolfsonmicro.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Jan 09, 2015 at 04:53:40PM +0800, Bo Shen wrote: > As the commit 5fe5b76 (ASoC: dapm: Do not pretend to support > controls for non mixer/mux widgets) remove the fake control. > > Then, the wm8904 throw out the following warning at runtime. > --->8--- > wm8904 1-001a: Control not supported for path ADCL -> [Left] -> AIFOUTL > wm8904 1-001a: ASoC: no dapm match for ADCL --> Left --> AIFOUTL > wm8904 1-001a: ASoC: Failed to add route ADCL -> Left -> AIFOUTL > wm8904 1-001a: Control not supported for path ADCR -> [Right] -> AIFOUTL > wm8904 1-001a: ASoC: no dapm match for ADCR --> Right --> AIFOUTL > wm8904 1-001a: ASoC: Failed to add route ADCR -> Right -> AIFOUTL > wm8904 1-001a: Control not supported for path ADCL -> [Left] -> AIFOUTR > wm8904 1-001a: ASoC: no dapm match for ADCL --> Left --> AIFOUTR > wm8904 1-001a: ASoC: Failed to add route ADCL -> Left -> AIFOUTR > wm8904 1-001a: Control not supported for path ADCR -> [Right] -> AIFOUTR > wm8904 1-001a: ASoC: no dapm match for ADCR --> Right --> AIFOUTR > wm8904 1-001a: ASoC: Failed to add route ADCR -> Right -> AIFOUTR > wm8904 1-001a: Control not supported for path AIFINR -> [Right] -> DACL > wm8904 1-001a: ASoC: no dapm match for AIFINR --> Right --> DACL > wm8904 1-001a: ASoC: Failed to add route AIFINR -> Right -> DACL > wm8904 1-001a: Control not supported for path AIFINL -> [Left] -> DACL > wm8904 1-001a: ASoC: no dapm match for AIFINL --> Left --> DACL > wm8904 1-001a: ASoC: Failed to add route AIFINL -> Left -> DACL > wm8904 1-001a: Control not supported for path AIFINR -> [Right] -> DACR > wm8904 1-001a: ASoC: no dapm match for AIFINR --> Right --> DACR > wm8904 1-001a: ASoC: Failed to add route AIFINR -> Right -> DACR > wm8904 1-001a: Control not supported for path AIFINL -> [Left] -> DACR > wm8904 1-001a: ASoC: no dapm match for AIFINL --> Left --> DACR > wm8904 1-001a: ASoC: Failed to add route AIFINL -> Left -> DACR > ---8<--- > > This patch is used to remove these warning. > > Signed-off-by: Bo Shen > --- > > sound/soc/codecs/wm8904.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/sound/soc/codecs/wm8904.c b/sound/soc/codecs/wm8904.c > index 4d2d2b1..38582d7 100644 > --- a/sound/soc/codecs/wm8904.c > +++ b/sound/soc/codecs/wm8904.c > @@ -1076,10 +1076,10 @@ static const struct snd_soc_dapm_route adc_intercon[] = { > { "Right Capture PGA", NULL, "Right Capture Mux" }, > { "Right Capture PGA", NULL, "Right Capture Inverting Mux" }, > > - { "AIFOUTL", "Left", "ADCL" }, > - { "AIFOUTL", "Right", "ADCR" }, > - { "AIFOUTR", "Left", "ADCL" }, > - { "AIFOUTR", "Right", "ADCR" }, > + { "AIFOUTL", NULL, "ADCL" }, > + { "AIFOUTL", NULL, "ADCR" }, > + { "AIFOUTR", NULL, "ADCL" }, > + { "AIFOUTR", NULL, "ADCR" }, Is this the right fix here? I am not super familiar with the driver but it appears to contain an "AIFOUTL Mux" control which is not connected to anything. Looks like maybe this is a mistake the mux is indeded to be included in the path? Feels like we should either remove the control as well or hook it into the path. Thanks, Charles