All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alan Cox <alan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging, addi_apci_1500: fix IRQ spew
Date: Fri, 9 Jan 2015 17:50:06 -0800	[thread overview]
Message-ID: <20150110015006.GA20327@kroah.com> (raw)
In-Reply-To: <20141210144140.3964.42851.stgit@localhost.localdomain>

On Wed, Dec 10, 2014 at 02:42:01PM +0000, Alan Cox wrote:
> The driver very carefully checks if the card is the IRQ source, and if it
> isn't thoughtfully spews crap at_dev_warn() level. Remove the spewage so it
> can be used on a shared interrupt line.
> 
> Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=88651
> Signed-off-by: Alan Cox <alan@linux.intel.com>
> ---
>  .../comedi/drivers/addi-data/hwdrv_apci1500.c      |    4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> index 0ea081e..b7b9857 100644
> --- a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> +++ b/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c
> @@ -2175,10 +2175,6 @@ static void apci1500_interrupt(int irq, void *d)
>  			devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
>  		/* Authorizes the main interrupt on the board */
>  		outb(0xD0, devpriv->iobase + APCI1500_Z8536_CONTROL_REGISTER);
> -	} else {
> -		dev_warn(dev->class_dev,
> -			"Interrupt from unknown source\n");
> -
>  	}
>  }
>  

No longer applies to my tree due to other changes in this driver :(

thanks,

greg k-h

      reply	other threads:[~2015-01-10  1:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10 14:42 [PATCH] staging, addi_apci_1500: fix IRQ spew Alan Cox
2015-01-10  1:50 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150110015006.GA20327@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=alan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.