All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: treding@nvidia.com, Dave Airlie <airlied@redhat.com>
Cc: dri-devel@lists.freedesktop.org
Subject: re: drm: Remove useless else block
Date: Sat, 10 Jan 2015 07:48:23 +0300	[thread overview]
Message-ID: <20150110044823.GA7177@mwanda> (raw)


Hi Dave,

There is a bad merge in drm-next and it causes a static checker warning.

The patch 2ca651d15aff: "drm: Remove useless else block" from Dec 10,
2014, leads to the following static checker warning:

	drivers/gpu/drm/drm_crtc.c:4380 drm_property_change_valid_get()
	info: ignoring unreachable code.

drivers/gpu/drm/drm_crtc.c
  4371                  }
  4372          } else {
  4373                  int i;
  4374                  for (i = 0; i < property->num_values; i++)
  4375                          if (property->values[i] == value)
  4376                                  return true;
  4377                  return false;
  4378          }
  4379  
  4380          for (i = 0; i < property->num_values; i++)
  4381                  if (property->values[i] == value)
  4382                          return true;
  4383          return false;

This block was in the else statement before, but now it's moved to here
as well.

  4384  }

regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2015-01-10  4:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150110044823.GA7177@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.