All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dvdauthor : new package
Date: Mon, 12 Jan 2015 09:28:00 +0100	[thread overview]
Message-ID: <20150112092800.08ce4350@free-electrons.com> (raw)
In-Reply-To: <54B317DE.9090105@ou.edu>

Dear Steve Kenton,

On Sun, 11 Jan 2015 18:39:58 -0600, Steve Kenton wrote:

> /data/bcdist/test/buildroot-2014.11/output/host/usr/include/libxml2/libxml/encoding.h:28:19: fatal error: iconv.h: No such file or directory
>  #include <iconv.h>

This is a *host* header, so it shouldn't be included when building a
target package.

>                    ^
> compilation terminated.
> make[3]: *** [readxml.o] Error 1
> 
> 
> diff -pruN buildroot-2014.11.ori/package/Config.in buildroot-2014.11/package/Config.in
> --- buildroot-2014.11.ori/package/Config.in	2014-12-01 03:19:00.000000000 -0600
> +++ buildroot-2014.11/package/Config.in	2015-01-11 17:44:27.920155192 -0600
> @@ -6,6 +6,7 @@ menu "Audio and video applications"
>  	source "package/alsa-utils/Config.in"
>  	source "package/aumix/Config.in"
>  	source "package/bellagio/Config.in"
> +	source "package/dvdauthor/Config.in"
>  	source "package/espeak/Config.in"
>  	source "package/faad2/Config.in"
>  	source "package/ffmpeg/Config.in"
> diff -pruN buildroot-2014.11.ori/package/dvdauthor/Config.in buildroot-2014.11/package/dvdauthor/Config.in
> --- buildroot-2014.11.ori/package/dvdauthor/Config.in	1969-12-31 18:00:00.000000000 -0600
> +++ buildroot-2014.11/package/dvdauthor/Config.in	2015-01-11 18:07:40.892181913 -0600
> @@ -0,0 +1,27 @@
> +config BR2_PACKAGE_DVDAUTHOR
> +	bool "dvdauthor"
> +	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE # libxml2 may be missing a dependency
> +	select BR2_PACKAGE_LIBXML2
> +	select BR2_PACKAGE_FREETYPE
> +	select BR2_PACKAGE_LIBPNG
> +	select BR2_PACKAGE_LIBDVDREAD
> +	depends on BR2_LARGEFILE && !BR2_PREFER_STATIC_LIB # libdvdread

BR2_PREFER_STATIC_LIB has been renamed to BR2_STATIC_LIBS. Please make
sure to test your patches against the latest master, since this is
where they will be applied.

> +# Note - Despite lack of a version bump the two line gentoo
> +# patch to src/spuunmux.c against "stock" dvdauthor-0.7.1
> +# -    if (setjmp(png_ptr->jmpbuf))
> +# +    if (setjmp(png_jmpbuf(png_ptr)))
> +# to allow use of libpng15/16 is already applied to downloadable
> +# dvdauthor-0.7.1.tar.gz

This should go to the commit log.

Also, does this means that your libpng12 patch is now unnecessary?

> +
> diff -pruN buildroot-2014.11.ori/package/dvdauthor/dvdauthor.mk buildroot-2014.11/package/dvdauthor/dvdauthor.mk
> --- buildroot-2014.11.ori/package/dvdauthor/dvdauthor.mk	1969-12-31 18:00:00.000000000 -0600
> +++ buildroot-2014.11/package/dvdauthor/dvdauthor.mk	2015-01-11 18:07:40.892181913 -0600
> @@ -0,0 +1,14 @@
> +###############################################################################
> +#
> +# dvdauthor
> +#
> +###############################################################################
> +
> +DVDAUTHOR_VERSION = 0.7.1
> +DVDAUTHOR_SITE = http://sourceforge.net/projects/dvdauthor/files/dvdauthor/$(DVDAUTHOR_VERSION)
> +DVDAUTHOR_DEPENDENCIES = host-pkgconf host-libxml2 host-freetype libxml2 freetype libpng libdvdread

I'm a little bit surprised by the need for host-libxml2 and
host-freetype, but I admittedly haven't looked in detail.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-01-12  8:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12  0:39 [Buildroot] [PATCH] dvdauthor : new package Steve Kenton
2015-01-12  8:28 ` Thomas Petazzoni [this message]
2015-01-12 15:33   ` Steve Kenton
2015-01-12 15:37     ` Thomas Petazzoni
2015-01-12 16:14       ` Steve Kenton
2015-01-12 17:26       ` Steve Kenton
2015-01-12 18:32         ` Thomas Petazzoni
2015-01-12 18:53           ` Steve Kenton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112092800.08ce4350@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.