Re: [nf-next] netfilter: acct: add support to accounters in nftables

[Pablo Neira Ayuso <pablo@netfilter.org>]

On Mon, Jan 12, 2015 at 11:45:39AM +0000, Patrick McHardy wrote:
> On 12.01, Pablo Neira Ayuso wrote:
> > > +/**
> > > + * struct nft_acct - nf_tables acct instance
> > > + *
> > > + * @list: table acct list node
> > > + * @name: name of the acct
> > > + * @pkts:  number of packets
> > > + * @bytes:  number of bytes
> > > + * use: number of rule references to this acct
> > > + */
> > > +struct nft_acct {
> > > +	struct list_head	list;
> > > +	char                    name[NFT_ACCT_MAXNAMELEN];
> > 
> > NFT_ACCT_MAXNAMELEN needs to be limited to 16 bytes, so we can easily
> > use acct objects from mappings.
> 
> Not saying that we need more than 16 bytes, but we'd hopefully use
> references instead of runtime resolved lookups in mappings :)

I just noticed Ana have to replace NFTA_ACCT_EXPR_NAME by
NFTA_ACCT_EXPR_SREG to support mappings.

What's your idea behind the references? Use some unique id to identify
the object instead of the name?