All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Gabriel Laskar <gabriel-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	David Herrmann
	<dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Peter Hutterer
	<peter.hutterer-Pf4JEFdB4epeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH 0/2] Input: uinput - fix ioctl numbers in uapi/uinput.h
Date: Mon, 12 Jan 2015 10:57:02 -0500	[thread overview]
Message-ID: <20150112155702.GA7941@mail.corp.redhat.com> (raw)
In-Reply-To: <20150112002943.GA31862@dtor-ws>

Hi,

On Jan 11 2015 or thereabouts, Dmitry Torokhov wrote:
> Hi Gabriel,
> 
> On Sat, Jan 10, 2015 at 01:43:34PM +0100, Gabriel Laskar wrote:
> > Ioctls numbers for UI_GET_SYSNAME and UI_GET_VERSION are incorrectly numbered,
> > since nr number is 8bit encoded, 300 and 301 will effectively get 44 and 45.
> > these two patches fixes this
> > 
> 
> Nice catch, thank you! I folded the patches together (as they are fixing
> essentially the same thing) , changed hex to dec (because the rest of
> ioctls in uinput use decimal) and applied.
> 
> I wonder if we need to put a BUILD_BUG_ON in one if _IO* defines to
> catch such errors early on.
> 

As others said, nice catch, thanks a lot. I feel very embarrassed about
this :(

Cheers,
Benjamin

      reply	other threads:[~2015-01-12 15:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-10 12:43 [PATCH 0/2] Input: uinput - fix ioctl numbers in uapi/uinput.h Gabriel Laskar
     [not found] ` <1420893816-11620-1-git-send-email-gabriel-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>
2015-01-10 12:43   ` [PATCH 1/2] Input: uinput - fix ioctl nr overflow for UI_GET_SYSNAME Gabriel Laskar
2015-01-10 12:43   ` [PATCH 2/2] Input: uinput - fix ioctl nr overflow for UI_GET_VERSION Gabriel Laskar
     [not found]     ` <1420893816-11620-3-git-send-email-gabriel-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org>
2015-01-12  0:37       ` Peter Hutterer
2015-01-12  0:29   ` [PATCH 0/2] Input: uinput - fix ioctl numbers in uapi/uinput.h Dmitry Torokhov
2015-01-12 15:57     ` Benjamin Tissoires [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150112155702.GA7941@mail.corp.redhat.com \
    --to=benjamin.tissoires-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=dh.herrmann-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=gabriel-tU7rkvAWjlwhT4uAktR2oQ@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=peter.hutterer-Pf4JEFdB4epeoWH0uzbU5w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.