From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Date: Mon, 12 Jan 2015 20:14:37 +0100 Message-ID: <20150112201437.07254212@armhf> References: <20150109130725.GN12302@n2100.arm.linux.org.uk> <54AFDE8D.3000504@arm.com> <20150109145741.GP12302@n2100.arm.linux.org.uk> <20150109183857.53d701a4@armhf> <20150109200127.GD12302@n2100.arm.linux.org.uk> <1421054728.3081.28.camel@pengutronix.de> <20150112122527.GF12302@n2100.arm.linux.org.uk> <1421071197.3081.44.camel@pengutronix.de> <20150112140456.GI12302@n2100.arm.linux.org.uk> <20150112181341.4a53ea24@armhf> <20150112175705.GN12302@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150112175705.GN12302@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Andrew Jackson , "linux-kernel@vger.kernel.org" , Jyri Sarha , Mark Brown , "dri-devel@lists.freedesktop.org" List-Id: alsa-devel@alsa-project.org T24gTW9uLCAxMiBKYW4gMjAxNSAxNzo1NzowNiArMDAwMApSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+IHdyb3RlOgoKPiBJIGRvbid0IHBhcnRpY3VsYXJs eSBsaWtlIHRoYXQgLSB0aGF0IG1ha2VzIHRoZSBhc3N1bXB0aW9uIHRoYXQgQVAwCj4gYWx3YXlz IG1lYW5zIEkyUy4gIFdoYXQgaWYgYSBmdXR1cmUgY2hpcCBkZWNpZGVzIHRvIGFsbG93IFNQRElG IG9uCj4gQVAwPyAgV2h5IHNob3VsZCB3ZSBuZWVkIHRvIHJlLWludmVudCB0aGUgYmluZGluZz8K PiAKPiBJTUhPLCBpdCB3b3VsZCBiZSBtdWNoIGJldHRlciB0byBtYWtlIHRoaXMgZXhwbGljaXQu CgpPSy4KCj4gTm90ZSB0aGF0IHRoZSAidmlkZW8tcG9ydHMiIGFuZCAiYXVkaW8tcG9ydHMiIGFy ZSBqdXN0IGxhYmVscyBpbiB0aGUKPiBEVCBmaWxlOyB0aGV5IGFyZW4ndCBjYXJyaWVkIHRocm91 Z2ggdG8gdGhlIHJlc3VsdGluZyBEVCBiaW5hcnkgZmlsZSwKPiBzbyB0aGV5IGRvbid0IGhhdmUg YW55IG1lYW5pbmcgdG8gdGhlIGtlcm5lbC4KClJpZ2h0LCBzbywgZWl0aGVyIHRoZSBwb3J0IHR5 cGUgbXVzdCBiZSBleHBsaWNpdGx5IGRlZmluZWQsIG9yIHRoZSBuYW1lCm9mIHRoZSBwcm9wZXJ0 eSBnaXZpbmcgdGhlIHBvcnQgdmFsdWUgYWxzbyBnaXZlcyB0aGUgcG9ydCB0eXBlCihueHAsdmlk ZW8tcG9ydCAvIG54cCxhdWRpby1wb3J0KS4KCi0tIApLZW4gYXIgYydoZW50YcOxCXwJICAgICAg KiogQnJlaXpoIGhhIExpbnV4IGF0YXYhICoqCkplZgkJfAkJaHR0cDovL21vaW5lamYuZnJlZS5m ci8KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932216AbbALTMn (ORCPT ); Mon, 12 Jan 2015 14:12:43 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:29362 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756785AbbALTMk convert rfc822-to-8bit (ORCPT ); Mon, 12 Jan 2015 14:12:40 -0500 Date: Mon, 12 Jan 2015 20:14:37 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: Philipp Zabel , Andrew Jackson , Jyri Sarha , Mark Brown , Dave Airlie , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Message-ID: <20150112201437.07254212@armhf> In-Reply-To: <20150112175705.GN12302@n2100.arm.linux.org.uk> References: <20150109130725.GN12302@n2100.arm.linux.org.uk> <54AFDE8D.3000504@arm.com> <20150109145741.GP12302@n2100.arm.linux.org.uk> <20150109183857.53d701a4@armhf> <20150109200127.GD12302@n2100.arm.linux.org.uk> <1421054728.3081.28.camel@pengutronix.de> <20150112122527.GF12302@n2100.arm.linux.org.uk> <1421071197.3081.44.camel@pengutronix.de> <20150112140456.GI12302@n2100.arm.linux.org.uk> <20150112181341.4a53ea24@armhf> <20150112175705.GN12302@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Jan 2015 17:57:06 +0000 Russell King - ARM Linux wrote: > I don't particularly like that - that makes the assumption that AP0 > always means I2S. What if a future chip decides to allow SPDIF on > AP0? Why should we need to re-invent the binding? > > IMHO, it would be much better to make this explicit. OK. > Note that the "video-ports" and "audio-ports" are just labels in the > DT file; they aren't carried through to the resulting DT binary file, > so they don't have any meaning to the kernel. Right, so, either the port type must be explicitly defined, or the name of the property giving the port value also gives the port type (nxp,video-port / nxp,audio-port). -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/