From: Greg KH <gregkh@linuxfoundation.org>
To: Andrew Milkovich <amilkovich@gmail.com>
Cc: benjamin.romer@unisys.com, david.kershner@unisys.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: virtpci: fixed coding style errors
Date: Mon, 12 Jan 2015 15:03:21 -0800 [thread overview]
Message-ID: <20150112230321.GA22984@kroah.com> (raw)
In-Reply-To: <20150112225353.GA22382@zenbook.hsd1.ca.comcast.net>
On Mon, Jan 12, 2015 at 02:53:53PM -0800, Andrew Milkovich wrote:
> Hi,
>
> On Fri, Jan 09, 2015 at 05:41:23PM -0800, Greg KH wrote:
> > On Wed, Dec 17, 2014 at 05:25:10PM -0800, Andrew Milkovich wrote:
> > > Fixed coding style errors per checkpatch.pl. Inline comments removed.
> >
> > What coding errors did you fix? Please be specific.
>
> Some inline comments were removed. Some talked about chanptr, which is known
> because the first argument is the chan.
>
> The other comments talked about no parent bus, but NULL signifies that there is
> no parent bus.
I was trying to hint that this needs to be in the changelog entry...
next prev parent reply other threads:[~2015-01-13 0:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-18 1:25 [PATCH] Staging: unisys: virtpci: fixed coding style errors Andrew Milkovich
2015-01-10 1:41 ` Greg KH
2015-01-12 22:53 ` Andrew Milkovich
2015-01-12 23:03 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-01-17 4:58 Andrew Milkovich
2015-01-18 0:22 ` Greg KH
2015-01-18 3:01 ` Andrew Milkovich
2015-01-18 3:07 ` Greg KH
2015-01-18 3:07 ` Andrew Milkovich
2015-01-18 3:11 Andrew Milkovich
2015-01-25 11:47 ` Greg KH
2015-01-18 3:30 Andrew Milkovich
2015-01-18 4:01 ` Joe Perches
2015-01-18 4:14 ` Andrew Milkovich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112230321.GA22984@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=amilkovich@gmail.com \
--cc=benjamin.romer@unisys.com \
--cc=david.kershner@unisys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.