From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/libftdi: fix libftdi.pc
Date: Tue, 13 Jan 2015 00:03:52 +0100 [thread overview]
Message-ID: <20150112230352.GB1879@free.fr> (raw)
In-Reply-To: <1421097965-15600-2-git-send-email-s.martin49@gmail.com>
Samuel, All,
On 2015-01-12 22:26 +0100, Samuel Martin spake thusly:
> This patch fixes libftdi pkg-config module, so that packages linking
> against libftdi correctly have all needed CFLAGS and LIBS defined,
> especially when running a static build.
>
> Fixes:
> http://autobuild.buildroot.org/results/e90/e90b4d5ad79d99487f21c9d18581e8eba7034501/
>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
This does indeed fix the autobuild failure.
However (as discussed on IRC), the real fix is a bit more involved, as
our current libftdi is 0.19, but openocd requires 0.20:
configure: WARNING: You need a newer libftdi version (0.20 or later)
[...]
MPSSE mode of FTDI based devices no
But as you said, this is material for a further patch. So:
Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> ...di.pc.in-requires-libusb-fix-static-build.patch | 25 ++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
> create mode 100644 package/libftdi/0002-libftdi.pc.in-requires-libusb-fix-static-build.patch
>
> diff --git a/package/libftdi/0002-libftdi.pc.in-requires-libusb-fix-static-build.patch b/package/libftdi/0002-libftdi.pc.in-requires-libusb-fix-static-build.patch
> new file mode 100644
> index 0000000..7b0d9c7
> --- /dev/null
> +++ b/package/libftdi/0002-libftdi.pc.in-requires-libusb-fix-static-build.patch
> @@ -0,0 +1,25 @@
> +From c0d957b08b46385da570d8ff2f728369822ad2c1 Mon Sep 17 00:00:00 2001
> +From: Samuel Martin <s.martin49@gmail.com>
> +Date: Mon, 12 Jan 2015 22:10:49 +0100
> +Subject: [PATCH] libftdi.pc.in: requires libusb (fix static build)
> +
> +Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> +---
> + libftdi.pc.in | 1 +
> + 1 file changed, 1 insertion(+)
> +
> +diff --git a/libftdi.pc.in b/libftdi.pc.in
> +index 2061b91..95eb491 100644
> +--- a/libftdi.pc.in
> ++++ b/libftdi.pc.in
> +@@ -6,6 +6,7 @@ includedir=@includedir@
> + Name: libftdi
> + Description: Library to program and control the FTDI USB controller
> + Requires:
> ++Requires.private: libusb
> + Version: @VERSION@
> + Libs: -L${libdir} -lftdi -lusb
> + Cflags: -I${includedir}
> +--
> +2.2.1
> +
> --
> 2.2.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-12 23:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 21:26 [Buildroot] [PATCH 1/2] package/libftdi: rename patches to the new naming convention Samuel Martin
2015-01-12 21:26 ` [Buildroot] [PATCH 2/2] package/libftdi: fix libftdi.pc Samuel Martin
2015-01-12 23:03 ` Yann E. MORIN [this message]
2015-01-13 13:15 ` Thomas Petazzoni
2015-01-19 22:47 ` Samuel Martin
2015-01-12 23:00 ` [Buildroot] [PATCH 1/2] package/libftdi: rename patches to the new naming convention Yann E. MORIN
2015-01-14 15:55 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150112230352.GB1879@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.