All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Emrys Bayliss <emrys@paradise.net.nz>,
	forest@alittletooquiet.net, tvboxspy@gmail.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return
Date: Tue, 13 Jan 2015 12:18:40 +0530	[thread overview]
Message-ID: <20150113064840.GA17714@sudip-PC> (raw)
In-Reply-To: <20150113062427.GA8265@sudip-PC>

On Tue, Jan 13, 2015 at 11:54:27AM +0530, Sudip Mukherjee wrote:
> On Mon, Jan 12, 2015 at 09:58:17PM -0800, Greg KH wrote:
> > On Tue, Jan 13, 2015 at 10:53:12AM +0530, Sudip Mukherjee wrote:
> > > 
> > > any reason why this return was removed ?
> > 
> > Because it's not needed.
> 
> yes, it is not needed. but the way Emrys Bayliss has changed the code, then we will get a compiler warning about no return statement.
i should have mentioned in my last mail that compiler will give waring if we compile with W=3 

sudip

> the code becomes :
> 

  reply	other threads:[~2015-01-13  6:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-12 16:51 [PATCH v2] Staging: vt6656: Checkpatch fix: else after break or return Emrys Bayliss
2015-01-13  5:23 ` Sudip Mukherjee
2015-01-13  5:58   ` Greg KH
2015-01-13  6:24     ` Sudip Mukherjee
2015-01-13  6:48       ` Sudip Mukherjee [this message]
2015-01-13 10:59         ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150113064840.GA17714@sudip-PC \
    --to=sudipm.mukherjee@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=emrys@paradise.net.nz \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.