From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly Date: Tue, 13 Jan 2015 20:15:49 +0530 Message-ID: <20150113144549.GC3085@intel.com> References: <1418989110-10011-1-git-send-email-qais.yousef@imgtec.com> <54B5048F.2070709@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by alsa0.perex.cz (Postfix) with ESMTP id DBE7C260434 for ; Tue, 13 Jan 2015 15:47:00 +0100 (CET) Content-Disposition: inline In-Reply-To: <54B5048F.2070709@imgtec.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Qais Yousef , Takashi Iwai Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org T24gVHVlLCBKYW4gMTMsIDIwMTUgYXQgMTE6NDI6MDdBTSArMDAwMCwgUWFpcyBZb3VzZWYgd3Jv dGU6Cj4gUGluZwo+IAo+IE9uIDEyLzE5LzIwMTQgMTE6MzggQU0sIFFhaXMgWW91c2VmIHdyb3Rl Ogo+ID5GaXhlcyB0aGUgZm9sbG93aW5nIGNvbXBpbGF0aW9uIGVycm9yOgo+ID4KPiA+ICAgIGlu Y2x1ZGUvc291bmQvY29tcHJlc3NfZHJpdmVyLmg6IEluIGZ1bmN0aW9uIOKAmHNuZF9jb21wcl9k cmFpbl9ub3RpZnnigJk6Cj4gPiAgICBpbmNsdWRlL3NvdW5kL2NvbXByZXNzX2RyaXZlci5oOjE3 NzoyOiBlcnJvcjogaW1wbGljaXQgZGVjbGFyYXRpb24gb2YgZnVuY3Rpb24g4oCYc25kX0JVR19P TuKAmSBbLVdlcnJvcj1pbXBsaWNpdC1mdW5jdGlvbi1kZWNsYXJhdGlvbl0KPiA+ICAgICAgaWYg KHNuZF9CVUdfT04oIXN0cmVhbSkpCj4gPgo+ID5zbmRfQlVHX09OKCkgaXMgZGVmaW5lZCBpbiBz b3VuZC9jb3JlLmggYnV0IHRoZSBmaWxlIGlzIG5vdCBpbmNsdWRlZCBleHBsaWNpdGx5LAo+ID5z byBpbmNsdWRlIGl0Lgo+ID4KPiA+U2lnbmVkLW9mZi1ieTogUWFpcyBZb3VzZWYgPHFhaXMueW91 c2VmQGltZ3RlYy5jb20+Cj4gPkNjOiBWaW5vZCBLb3VsIDx2aW5vZC5rb3VsQGludGVsLmNvbT4K PiA+Q2M6IEphcm9zbGF2IEt5c2VsYSA8cGVyZXhAcGVyZXguY3o+Cj4gPkNjOiBUYWthc2hpIEl3 YWkgPHRpd2FpQHN1c2UuZGU+Cj4gPkNjOiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4g PgpMb29rcyBva2F5IHRvIG1lCgpBY2tlZC1ieTogVmlub2QgS291bCA8dmlub2Qua291bEBpbnRl bC5jb20+CgpUaGFua3MKLS0gCn5WaW5vZAoKPiA+LS0tCj4gPiAgaW5jbHVkZS9zb3VuZC9jb21w cmVzc19kcml2ZXIuaCB8IDEgKwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+ ID4KPiA+ZGlmZiAtLWdpdCBhL2luY2x1ZGUvc291bmQvY29tcHJlc3NfZHJpdmVyLmggYi9pbmNs dWRlL3NvdW5kL2NvbXByZXNzX2RyaXZlci5oCj4gPmluZGV4IDM5NmU4ZjczNjcwYS4uMWUyNTMx MDU4YjdlIDEwMDY0NAo+ID4tLS0gYS9pbmNsdWRlL3NvdW5kL2NvbXByZXNzX2RyaXZlci5oCj4g PisrKyBiL2luY2x1ZGUvc291bmQvY29tcHJlc3NfZHJpdmVyLmgKPiA+QEAgLTI3LDYgKzI3LDcg QEAKPiA+ICAjaW5jbHVkZSA8bGludXgvdHlwZXMuaD4KPiA+ICAjaW5jbHVkZSA8bGludXgvc2No ZWQuaD4KPiA+KyNpbmNsdWRlIDxzb3VuZC9jb3JlLmg+Cj4gPiAgI2luY2x1ZGUgPHNvdW5kL2Nv bXByZXNzX29mZmxvYWQuaD4KPiA+ICAjaW5jbHVkZSA8c291bmQvYXNvdW5kLmg+Cj4gPiAgI2lu Y2x1ZGUgPHNvdW5kL3BjbS5oPgo+IAoKLS0gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFsc2EtZGV2ZWxAYWxz YS1wcm9qZWN0Lm9yZwpodHRwOi8vbWFpbG1hbi5hbHNhLXByb2plY3Qub3JnL21haWxtYW4vbGlz dGluZm8vYWxzYS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752870AbbAMOrA (ORCPT ); Tue, 13 Jan 2015 09:47:00 -0500 Received: from mga14.intel.com ([192.55.52.115]:4329 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbbAMOq7 (ORCPT ); Tue, 13 Jan 2015 09:46:59 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,750,1413270000"; d="scan'208";a="636632732" Date: Tue, 13 Jan 2015 20:15:49 +0530 From: Vinod Koul To: Qais Yousef , Takashi Iwai Cc: alsa-devel@alsa-project.org, Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: compress_driver.h: include sound/core.h explicitly Message-ID: <20150113144549.GC3085@intel.com> References: <1418989110-10011-1-git-send-email-qais.yousef@imgtec.com> <54B5048F.2070709@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54B5048F.2070709@imgtec.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 13, 2015 at 11:42:07AM +0000, Qais Yousef wrote: > Ping > > On 12/19/2014 11:38 AM, Qais Yousef wrote: > >Fixes the following compilation error: > > > > include/sound/compress_driver.h: In function ‘snd_compr_drain_notify’: > > include/sound/compress_driver.h:177:2: error: implicit declaration of function ‘snd_BUG_ON’ [-Werror=implicit-function-declaration] > > if (snd_BUG_ON(!stream)) > > > >snd_BUG_ON() is defined in sound/core.h but the file is not included explicitly, > >so include it. > > > >Signed-off-by: Qais Yousef > >Cc: Vinod Koul > >Cc: Jaroslav Kysela > >Cc: Takashi Iwai > >Cc: linux-kernel@vger.kernel.org > > Looks okay to me Acked-by: Vinod Koul Thanks -- ~Vinod > >--- > > include/sound/compress_driver.h | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h > >index 396e8f73670a..1e2531058b7e 100644 > >--- a/include/sound/compress_driver.h > >+++ b/include/sound/compress_driver.h > >@@ -27,6 +27,7 @@ > > #include > > #include > >+#include > > #include > > #include > > #include > --