From: Mark Brown <broonie@kernel.org>
To: Qais Yousef <qais.yousef@imgtec.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference
Date: Tue, 13 Jan 2015 16:20:04 +0000 [thread overview]
Message-ID: <20150113162004.GR4160@sirena.org.uk> (raw)
In-Reply-To: <54B536BA.3070001@imgtec.com>
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
On Tue, Jan 13, 2015 at 03:16:10PM +0000, Qais Yousef wrote:
> On 01/13/2015 02:59 PM, Vinod Koul wrote:
> >>being NULL, hence when trying to set rtd a few lines below we get an oops.
> >It is a good practice to add the oops here
> Will this really be helpful? I think it'll be more clutter (the backtrace on
> metag arch is not great):
It's better in general to leave it out unless it's adding something (for
example sometimes the particular call path is important) and even there
edit it down to relevant details - the splat from the full oops normally
overwhelms the commit message.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-01-13 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 11:18 [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference Qais Yousef
2015-01-13 11:18 ` Qais Yousef
2015-01-13 14:59 ` Vinod Koul
2015-01-13 14:59 ` Vinod Koul
2015-01-13 15:16 ` Qais Yousef
2015-01-13 15:16 ` Qais Yousef
2015-01-13 16:20 ` Mark Brown [this message]
2015-01-14 7:53 ` Qais Yousef
2015-01-14 7:53 ` Qais Yousef
2015-01-13 17:21 ` James Hogan
2015-01-14 8:00 ` Qais Yousef
2015-01-14 8:00 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113162004.GR4160@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=qais.yousef@imgtec.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.