From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Date: Tue, 13 Jan 2015 16:54:11 +0100 Message-ID: <20150113165411.5469930d@armhf> References: <20150109145741.GP12302@n2100.arm.linux.org.uk> <20150109183857.53d701a4@armhf> <20150109200127.GD12302@n2100.arm.linux.org.uk> <1421054728.3081.28.camel@pengutronix.de> <20150112122527.GF12302@n2100.arm.linux.org.uk> <1421071197.3081.44.camel@pengutronix.de> <20150112140456.GI12302@n2100.arm.linux.org.uk> <20150112181341.4a53ea24@armhf> <20150112175705.GN12302@n2100.arm.linux.org.uk> <1421151718.4519.24.camel@pengutronix.de> <20150113122715.GP12302@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150113122715.GP12302@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Andrew Jackson , "linux-kernel@vger.kernel.org" , Jyri Sarha , Mark Brown , "dri-devel@lists.freedesktop.org" List-Id: alsa-devel@alsa-project.org T24gVHVlLCAxMyBKYW4gMjAxNSAxMjoyNzoxNSArMDAwMApSdXNzZWxsIEtpbmcgLSBBUk0gTGlu dXggPGxpbnV4QGFybS5saW51eC5vcmcudWs+IHdyb3RlOgoKPiBPbiBUdWUsIEphbiAxMywgMjAx NSBhdCAwMToyMTo1OFBNICswMTAwLCBQaGlsaXBwIFphYmVsIHdyb3RlOgo+ID4gSSB3b25kZXIg aWYgaXQgd291bGRuJ3QgYmUgbmljZXIgdG8gaGF2ZSB0aGUgQVAjIGFuZCB0eXBlIGluIHRoZSBk ZXZpY2UKPiA+IHRyZWUgYW5kIHRoZW4gY2FsY3VsYXRlIHRoZSByZWdpc3RlciB2YWx1ZSBmcm9t IHRoYXQgaW4gdGhlIGRyaXZlci4KPiA+IAo+ID4gCXBvcnRAMSB7Cj4gPiAJCXJlZyA9IDwxPjsg LyogQVAxICovCj4gPiAJCW54cCxhdWRpby1wb3J0ID0gImkycyI7Cj4gPiAJCXRkYTk5OHhfaTJz OiBlbmRwb2ludCB7Cj4gPiAJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JmF1ZGlvMV9pMnM+Owo+ID4g CQl9Owo+ID4gCX07Cj4gCj4gV2hhdCBhYm91dCB0aGUgY2FzZSB3aGVyZSB3ZSBoYXZlIDQgSTJT IHN0cmVhbXMgYmVpbmcgc3VwcGxpZWQgdG8gdGhlCj4gZGV2aWNlIG9uIGZvdXIgc2VwYXJhdGUg QVAgaW5wdXRzPwoKNCBzdHJlYW1zIG9uIDQgZGlmZmVyZW50IEFQcyAoc291cmNlcykgc2hvdWxk IHdvcmssIGJ1dCA0IHN0cmVhbXMgZnJvbQphIHNhbWUgc291cmNlIHNob3VsZCBiZSBkZXRhaWxl ZC4KCkluIGFuIG90aGVyIHdheSwgdGhlIHVuaXQgYWRkcmVzcyAoPT0gZmlyc3QgcmVnKSBkb2Vz IG5vdCBuZWVkIHRvIGJlIGEKc2VxdWVuY2UgbnVtYmVyLiBJdCBpcyB0aGUgSS9PIGJhc2UgaW4g bW9zdCBEVHMuClNvLCBpdCBjb3VsZCBiZSB0aGUgcG9ydCB2YWx1ZTogCgoJcG9ydEAyMzAxNDUg ewoJCXBvcnQtdHlwZSA9ICJyZ2IiOwoJCXJlZyA9IDwweDIzMDE0NT47CgkJaGRtaV8wOiBlbmRw b2ludCB7CgkJCXJlbW90ZS1lbmRwb2ludCA9IDwmbGNkMF8wPjsKCQl9OwoJfTsKCXBvcnRAMyB7 CQkJLyogQVAxID0gSTJTICovCgkJcG9ydC10eXBlID0gImkycyI7CgkJcmVnID0gPDB4MDM+OwoJ CXRkYTk5OHhfaTJzOiBlbmRwb2ludCB7CgkJCXJlbW90ZS1lbmRwb2ludCA9IDwmYXVkaW8xX2ky cz47CgkJfTsKCX07Cglwb3J0QDQgewkJCSAvKiBBUDIgPSBTL1BESUYgKi8KCQlwb3J0LXR5cGUg PSAic3BkaWYiOwoJCXJlZyA9IDwweDA0PjsKCQl0ZGE5OTh4X3NwZGlmOiBlbmRwb2ludCB7CgkJ CXJlbW90ZS1lbmRwb2ludCA9IDwmYXVkaW8xX3NwZGlmMT47CgkJfTsKCX07CgotLSAKS2VuIGFy IGMnaGVudGHDsQl8CSAgICAgICoqIEJyZWl6aCBoYSBMaW51eCBhdGF2ISAqKgpKZWYJCXwJCWh0 dHA6Ly9tb2luZWpmLmZyZWUuZnIvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbbAMPyc (ORCPT ); Tue, 13 Jan 2015 10:54:32 -0500 Received: from smtp6-g21.free.fr ([212.27.42.6]:40338 "EHLO smtp6-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752285AbbAMPya convert rfc822-to-8bit (ORCPT ); Tue, 13 Jan 2015 10:54:30 -0500 Date: Tue, 13 Jan 2015 16:54:11 +0100 From: Jean-Francois Moine To: Russell King - ARM Linux Cc: Philipp Zabel , Andrew Jackson , Jyri Sarha , Mark Brown , Dave Airlie , "alsa-devel@alsa-project.org" , "devicetree@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v9 1/4] drm/i2c: tda998x: Add DT support for audio Message-ID: <20150113165411.5469930d@armhf> In-Reply-To: <20150113122715.GP12302@n2100.arm.linux.org.uk> References: <20150109145741.GP12302@n2100.arm.linux.org.uk> <20150109183857.53d701a4@armhf> <20150109200127.GD12302@n2100.arm.linux.org.uk> <1421054728.3081.28.camel@pengutronix.de> <20150112122527.GF12302@n2100.arm.linux.org.uk> <1421071197.3081.44.camel@pengutronix.de> <20150112140456.GI12302@n2100.arm.linux.org.uk> <20150112181341.4a53ea24@armhf> <20150112175705.GN12302@n2100.arm.linux.org.uk> <1421151718.4519.24.camel@pengutronix.de> <20150113122715.GP12302@n2100.arm.linux.org.uk> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Jan 2015 12:27:15 +0000 Russell King - ARM Linux wrote: > On Tue, Jan 13, 2015 at 01:21:58PM +0100, Philipp Zabel wrote: > > I wonder if it wouldn't be nicer to have the AP# and type in the device > > tree and then calculate the register value from that in the driver. > > > > port@1 { > > reg = <1>; /* AP1 */ > > nxp,audio-port = "i2s"; > > tda998x_i2s: endpoint { > > remote-endpoint = <&audio1_i2s>; > > }; > > }; > > What about the case where we have 4 I2S streams being supplied to the > device on four separate AP inputs? 4 streams on 4 different APs (sources) should work, but 4 streams from a same source should be detailed. In an other way, the unit address (== first reg) does not need to be a sequence number. It is the I/O base in most DTs. So, it could be the port value: port@230145 { port-type = "rgb"; reg = <0x230145>; hdmi_0: endpoint { remote-endpoint = <&lcd0_0>; }; }; port@3 { /* AP1 = I2S */ port-type = "i2s"; reg = <0x03>; tda998x_i2s: endpoint { remote-endpoint = <&audio1_i2s>; }; }; port@4 { /* AP2 = S/PDIF */ port-type = "spdif"; reg = <0x04>; tda998x_spdif: endpoint { remote-endpoint = <&audio1_spdif1>; }; }; -- Ken ar c'hentañ | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/