From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Krzysztof Adamski <k@japko.eu>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private members.
Date: Tue, 13 Jan 2015 10:52:00 -0800 [thread overview]
Message-ID: <20150113185200.GA25686@kroah.com> (raw)
In-Reply-To: <20150113184227.GK30114@box2.japko.eu>
On Tue, Jan 13, 2015 at 07:42:28PM +0100, Krzysztof Adamski wrote:
> On Mon, Jan 12, 2015 at 07:42:12PM -0800, Greg Kroah-Hartman wrote:
> >On Mon, Dec 22, 2014 at 05:15:41PM +0100, Krzysztof Adamski wrote:
> >>This patch fixes checkpatch.pl warning:
> >>WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
> >>addresses are __aligned(2)
> >>
> >>current_net_addr and permanent_net_addr members of vnt_private alignment
> >>is changed to at last 16 bits so that ether_addr_copy can be safely used
> >>on them.
> >>
> >>buf->data is of type ieee80211_cts which is already properly aligned.
> >>
> >>Signed-off-by: Krzysztof Adamski <k@japko.eu>
> >>---
> >>drivers/staging/vt6656/device.h | 4 ++--
> >>drivers/staging/vt6656/main_usb.c | 3 ++-
> >>drivers/staging/vt6656/rxtx.c | 4 ++--
> >>3 files changed, 6 insertions(+), 5 deletions(-)
> >
> >Doesn't apply to my tree :(
>
> Strange, I was trying to apply this on your tree to fix any conflicts but
> apparently you already has this patch in your staging-testing branch. And as
> far as I can tell I only sent it once to you.
I think you sent it lots of times, if it's there already, don't worry
about it :)
thanks,
greg k-h
next prev parent reply other threads:[~2015-01-13 18:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 16:15 [PATCH] staging: vt6656: Use ether_addr_copy() on vnt_private members Krzysztof Adamski
2015-01-13 3:42 ` Greg Kroah-Hartman
2015-01-13 18:42 ` Krzysztof Adamski
2015-01-13 18:52 ` Greg Kroah-Hartman [this message]
2015-01-13 18:59 ` Krzysztof Adamski
2015-01-13 19:10 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2014-12-09 11:01 Krzysztof Adamski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150113185200.GA25686@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=k@japko.eu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.