From: Matt Roper <matthew.d.roper@intel.com>
To: Sonika Jindal <sonika.jindal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Adding rotation to drm_plane_helper_check_update
Date: Wed, 14 Jan 2015 08:32:48 -0800 [thread overview]
Message-ID: <20150114163248.GF29482@intel.com> (raw)
In-Reply-To: <1421214054-30393-1-git-send-email-sonika.jindal@intel.com>
On Wed, Jan 14, 2015 at 11:10:54AM +0530, Sonika Jindal wrote:
> Taking rotation into account while checking the plane
> and adjusting the sizes accordingly.
>
> v2: Adding parameter in the callers in the same patch(Matt)
> Removing unnecessary code and allowing scaling(Ville)
>
> Signed-off-by: Sonika Jindal <sonika.jindal@intel.com>
> ---
...
> EXPORT_SYMBOL(drm_plane_helper_check_update);
> @@ -258,7 +293,8 @@ int drm_primary_helper_update(struct drm_plane *plane, struct drm_crtc *crtc,
> &src, &dest, &clip,
> DRM_PLANE_HELPER_NO_SCALING,
> DRM_PLANE_HELPER_NO_SCALING,
> - false, false, &visible);
> + false, false, &visible,
> + DRM_ROTATE_0);
I think this needs to be BIT(DRM_ROTATE_0)?
...
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index e7ca25b..4813a53 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -551,7 +551,8 @@ static int vop_update_plane_event(struct drm_plane *plane,
> &src, &dest, &clip,
> DRM_PLANE_HELPER_NO_SCALING,
> DRM_PLANE_HELPER_NO_SCALING,
> - can_position, false, &visible);
> + can_position, false, &visible,
> + DRM_ROTATE_0);
Same here.
Matt
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-14 16:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 12:33 [PATCH 0/2] Adding rotattion to drm_plane_helper_check_update Sonika Jindal
2015-01-13 12:33 ` [PATCH 1/2] drm: Adding rotation " Sonika Jindal
2015-01-13 13:32 ` [Intel-gfx] " Ville Syrjälä
2015-01-14 4:35 ` sonika
2015-01-14 9:27 ` Ville Syrjälä
2015-01-14 9:35 ` [Intel-gfx] " Jindal, Sonika
2015-01-14 9:49 ` Jindal, Sonika
2015-01-14 11:43 ` Ville Syrjälä
2015-01-14 13:54 ` Jindal, Sonika
2015-01-14 18:08 ` Ville Syrjälä
2015-01-15 2:04 ` [Intel-gfx] " Jindal, Sonika
2015-01-15 9:28 ` Ville Syrjälä
2015-01-14 5:40 ` [PATCH] " Sonika Jindal
2015-01-14 16:32 ` Matt Roper [this message]
2015-01-15 10:39 ` shuang.he
2015-01-13 12:33 ` [PATCH 2/2] drm/i915: Passing " Sonika Jindal
2015-01-13 19:36 ` shuang.he
2015-01-13 18:12 ` [PATCH 0/2] Adding rotattion " Matt Roper
2015-01-14 4:24 ` sonika
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114163248.GF29482@intel.com \
--to=matthew.d.roper@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sonika.jindal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.