From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH v3 15/19] libxc: allocate memory with vNUMA
 information for HVM guest
Date: Wed, 14 Jan 2015 14:02:59 -0500
Message-ID: <20150114190259.GD2013@l.oracle.com>
References: <1421151107-20842-1-git-send-email-wei.liu2@citrix.com>
	<1421151107-20842-16-git-send-email-wei.liu2@citrix.com>
	<20150113181521.GB18027@localhost.localdomain>
	<20150113204429.GA17391@zion.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <20150113204429.GA17391@zion.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, dario.faggioli@citrix.com, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, jbeulich@suse.com, Elena Ufimtseva <ufimtseva@gmail.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, Jan 13, 2015 at 08:44:29PM +0000, Wei Liu wrote:
> On Tue, Jan 13, 2015 at 01:15:21PM -0500, Konrad Rzeszutek Wilk wrote:
> > On Tue, Jan 13, 2015 at 12:11:43PM +0000, Wei Liu wrote:
> > > The algorithm is more or less the same as the one used for PV guest.
> > > Libxc gets hold of the mapping of vnode to pnode and size of each vnode
> > > then allocate memory accordingly.
> > 
> > Could you split this patch in two? One part for the adding of the code
> > and the other for moving the existing code around?
> > 
> 
> The structures added are just a few lines. On one hand two Ians
> complained I wrote patches that only added structures, on the other you
> complained I bundled them with functional code. It's hard to please
> everyone isn't it. :-)
> 
> Jokes aside, I'm not sure if the above paragraph answers your question.
> Which part of code is "added" and which part of code is "moved around"?

The existing code that is just moved by tab could have a seperate patch
which is a non-functional. That is - it does not change the behavior
of the code - just moves it around.
> 
> Wei.