From: Ben Widawsky <ben@bwidawsk.net>
To: "O'Rourke, Tom" <Tom.O'Rourke@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
"Widawsky, Benjamin" <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] [v2] intel_frequency: A tool to manipulate Intel GPU frequency
Date: Wed, 14 Jan 2015 16:51:40 -0800 [thread overview]
Message-ID: <20150115005139.GA10003@bwidawsk.net> (raw)
In-Reply-To: <20150114174224.GA4739@torourke-desk1>
On Wed, Jan 14, 2015 at 09:42:24AM -0800, O'Rourke, Tom wrote:
> On Tue, Jan 13, 2015 at 02:36:56PM -0800, Ben Widawsky wrote:
> > On Tue, Jan 13, 2015 at 09:19:04PM +0000, O'Rourke, Tom wrote:
> > > >Sent: Sunday, January 11, 2015 7:48 PM
> > > >To: Widawsky, Benjamin
> > > >Cc: Intel GFX
> > > >Subject: Re: [Intel-gfx] [PATCH] [v2] intel_frequency: A tool to manipulate Intel
> > > >GPU frequency
> > > >
> > > >On Sun, Jan 11, 2015 at 07:35:21PM -0800, Ben Widawsky wrote:
> > > >> WARNING: very minimally tested
> > > >>
> > > >> In general you should not need this tool. It's primary purpose is for
> > > >> benchmarking, and for debugging performance issues.
> > > >
> > > >I noticed the "it's" vs "its" on v1, but forgot to fix it. IT'S fixed locally
> > > >though.
> > > >
> > > >>
> > > >> For many kernel releases now sysfs has supported reading and writing the GPU
> > > >> frequency. Therefore, this tool provides no new functionality. What it does
> > > >> provide is an easy to package (for distros) tool that handles the most common
> > > >> scenarios.
> > > [TOR:] This is a nice tool.
> > > I am concerned that this tool may be confusing RP1 frequency with RPe (Efficient) frequency. On many platforms, these are not the same thing.
> > > Thanks,
> > > Tom O'Rourke
> > >
> >
> > Any platform other than BYT/CHV?
>
> [TOR:] I am thinking about Haswell and Broadwell. The RP1
> value can be read from RP_STATE_CAP while the RPe value can
> be read from PCU mailbox. Do we need to add a sysfs entry
> for RPe?
>
Yeah - I didn't know it existed. Let's add that. Updating the tool afterward is
easy. Do we ever want Rp1?
[snip]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-01-15 0:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-11 4:19 [PATCH 1/2] tools/Makefile: Alphabetize the list Ben Widawsky
2015-01-11 4:19 ` [PATCH 2/2] intel_frequency: A tool to manipulate Intel GPU frequency Ben Widawsky
2015-01-11 4:36 ` Ben Widawsky
2015-01-11 17:54 ` Jordan Justen
2015-01-12 3:35 ` [PATCH] [v2] " Ben Widawsky
2015-01-12 3:47 ` Ben Widawsky
2015-01-13 21:19 ` O'Rourke, Tom
2015-01-13 22:36 ` Ben Widawsky
2015-01-14 17:42 ` O'Rourke, Tom
2015-01-15 0:51 ` Ben Widawsky [this message]
2015-01-15 14:00 ` Dave Gordon
2015-01-15 17:24 ` Dave Gordon
2015-01-15 21:15 ` Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115005139.GA10003@bwidawsk.net \
--to=ben@bwidawsk.net \
--cc=Tom.O'Rourke@intel.com \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.