Re: [PATCH] fdtput: add delete node and property function

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]

On Thu, Jan 15, 2015 at 12:11:18PM +0800, long.wanglong wrote:
> On 2015/1/15 11:08, David Gibson wrote:
> > On Tue, Jan 13, 2015 at 08:07:59PM -0800, Simon Glass wrote:
> >> Hi Wang,
> >>
> >> On 13 January 2015 at 19:53, Wang Long <long.wanglong-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> wrote:
> >>> add the delete node and property function for fdtput.
> >>>
> >>> usage:
> >>> 1) delete a node
> >>>  # fdtput test.dtb -d node /chosen/son
> >>> 2) delete a property
> >>>  # fdtput test.dtb -d prop /chosen/ prop_name
> >>
> >> This is a great addition!
> >>
> >> I know David is keen on single character flags. But would it be better
> >> to have a separate delete option, e.g.
> > 
> > Well.. it's not that I'm actually keen on them.  Just that I haven't
> > thought the bother of another dependency adding a long options library
> > was worth it so far.
> > 
> >> -r to remove a node
> >> -d to delete a property
> > 
> > I like that suggestion better than "-d node" and "-d prop".
> > 
> 
> ok.
> 
> > But I wonder if it might be even simpler to just base it on the number
> > of arguments so:
> > 
> > $ fdtput foo.dtb -d /node@1234 some-property
> > 
> > will delete a single property, but
> > 
> > $ fdtput foo.dtb -d /node@1234
> > 
> > will delete the whole node.
> > 
> 
> Hi David Gibson,
> 
> if we decide to delete node or property based on the number of the arguments.
> we just delete a node or a property at once.
> 
> how about the following suggestion:
> 
> $ fdtput -r <options> <dt file> [<node>...]
> 
> will delete several nodes,
> 
> $ fdtput -d <options> <dt file> <node> [<property>...]
> 
> will delete several properties in a node.
> 
> the `fdtput` can create several nodes at once. so i think that it should to delete
> several nodes at once.

Good point, I forgot that the other options can do multiple operations
in a single command.

Your suggestion sounds good to me.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]