From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olaf Hering <olaf@aepfle.de>
Subject: Re: [PATCH] Fix building error
Date: Thu, 15 Jan 2015 08:57:46 +0100
Message-ID: <20150115075746.GA22946@aepfle.de>
References: <1417435968.29138.19.camel@citrix.com>
	<1417443665-30809-1-git-send-email-euan.harris@citrix.com>
	<54B73658.6030309@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <54B73658.6030309@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wen Congyang <wency@cn.fujitsu.com>
Cc: Euan Harris <euan.harris@citrix.com>, Ian.Jackson@eu.citrix.com, Ian.Campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, Jan 15, Wen Congyang wrote:

> Commit 1166ecf7 disables optimization. But python's build
> process may use CFLAGS -Wp,-D_FORTIFY_SOURCE=2, and suppose
> the 3rd party python modules to use. The macro _FORTIFY_SOURCE
> requires compiling with optimization (-O). Disable _FORTIFY_SOURCE
> by appending -Wp,-U_FORTIFY_SOURCE to CFLAGS.

Why is that not done globally, in the place where -O is tweaked?
The comment can be removed, it states the obvious.

Olaf