diff for duplicates of <20150115102824.GB6201@mwanda> diff --git a/a/1.txt b/N1/1.txt index 8b27406..4c348fc 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,7 +18,7 @@ The problem is in later iterations. > for (i = 0; i < nr_efi_runtime_map; i++) { > entry = add_sysfs_runtime_map_entry(efi_kobj, i); -Assume that this is the second iteration and "i = 1". +Assume that this is the second iteration and "i == 1". > if (IS_ERR(entry)) { > ret = PTR_ERR(entry); @@ -35,7 +35,7 @@ Assume it fails so we hit this goto. We want to free the first entry. > for (j = i - 1; j > 0; j--) { > entry = *(map_entries + j); -In your code, "j = 1 - 1" and that's not greater than zero so we don't +In your code, "j == 1 - 1" and that's not greater than zero so we don't enter this loop. In my code, we go through the loop one time. By the way this code would be a lot more clear if you used arrays. diff --git a/a/content_digest b/N1/content_digest index 8dabf82..3131c68 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,9 @@ "ref\020150115092121.GA17976@mwanda\0" "ref\020150115095455.GA15197@darkstar.redhat.com\0" "ref\020150115095455.GA15197-4/PLUo9XfK/1wF9wiOj0lkEOCMrvLtNR@public.gmane.org\0" - "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" + "From\0Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>\0" "Subject\0Re: [patch] efi: small leak on error\0" - "Date\0Thu, 15 Jan 2015 10:28:24 +0000\0" + "Date\0Thu, 15 Jan 2015 13:28:24 +0300\0" "To\0Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>\0" "Cc\0Matt Fleming <matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>" linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org @@ -30,7 +30,7 @@ "> \tfor (i = 0; i < nr_efi_runtime_map; i++) {\n" "> \t\tentry = add_sysfs_runtime_map_entry(efi_kobj, i);\n" "\n" - "Assume that this is the second iteration and \"i = 1\".\n" + "Assume that this is the second iteration and \"i == 1\".\n" "\n" "> \t\tif (IS_ERR(entry)) {\n" "> \t\t\tret = PTR_ERR(entry);\n" @@ -47,7 +47,7 @@ "> \tfor (j = i - 1; j > 0; j--) {\n" "> \t\tentry = *(map_entries + j);\n" "\n" - "In your code, \"j = 1 - 1\" and that's not greater than zero so we don't\n" + "In your code, \"j == 1 - 1\" and that's not greater than zero so we don't\n" "enter this loop. In my code, we go through the loop one time.\n" "\n" "By the way this code would be a lot more clear if you used arrays.\n" @@ -57,4 +57,4 @@ "regards,\n" dan carpenter -3ea9773773840e675c602bb433cd0262d8f55574e4b05c6b97f1640e1fa3a20f +c64210a0cbb57918edb3ea501dda626cbbcc3d7f9d51e07cfee81e544c3eb690
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.