From: Brian Foster <bfoster@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: Remove useless test
Date: Thu, 15 Jan 2015 08:27:54 -0500 [thread overview]
Message-ID: <20150115132754.GA23696@bfoster.bfoster> (raw)
In-Reply-To: <1421317085-14350-2-git-send-email-jack@suse.cz>
On Thu, Jan 15, 2015 at 11:18:03AM +0100, Jan Kara wrote:
> Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_quotaops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> index 7542bbeca6a1..8fcd20dbf89a 100644
> --- a/fs/xfs/xfs_quotaops.c
> +++ b/fs/xfs/xfs_quotaops.c
> @@ -75,7 +75,7 @@ xfs_fs_set_xstate(
>
> if (sb->s_flags & MS_RDONLY)
> return -EROFS;
> - if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
> + if (!XFS_IS_QUOTA_RUNNING(mp))
> return -ENOSYS;
>
> if (uflags & FS_QUOTA_UDQ_ACCT)
> --
> 2.1.2
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-01-15 13:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 10:18 [PATCH 0/3] xfs: Quota related cleanups Jan Kara
2015-01-15 10:18 ` [PATCH 1/3] xfs: Remove useless test Jan Kara
2015-01-15 13:27 ` Brian Foster [this message]
2015-01-20 16:44 ` Jan Kara
2015-01-20 22:14 ` Dave Chinner
2015-01-20 22:35 ` Jan Kara
2015-01-20 23:14 ` Dave Chinner
2015-01-15 10:18 ` [PATCH 2/3] xfs: Remove some useless flags tests Jan Kara
2015-01-15 13:28 ` Brian Foster
2015-01-15 10:18 ` [PATCH 3/3] xfs: Remove some pointless quota checks Jan Kara
2015-01-15 13:28 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115132754.GA23696@bfoster.bfoster \
--to=bfoster@redhat.com \
--cc=jack@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.