From: Shaohua Li <shli@fb.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <kafai@fb.com>
Subject: Re: net_test_tools: add ipv6 support for kbench_mod
Date: Thu, 15 Jan 2015 13:17:37 -0800 [thread overview]
Message-ID: <20150115211737.GA2587066@devbig257.prn2.facebook.com> (raw)
In-Reply-To: <20150114.013540.1963709251689177055.davem@davemloft.net>
On Wed, Jan 14, 2015 at 01:35:40AM -0500, David Miller wrote:
> From: Shaohua Li <shli@fb.com>
> Date: Tue, 13 Jan 2015 21:45:48 -0800
>
> > This patch adds ipv6 support for kbench_mod test module
>
> This doesn't even link because ip6_route_input is not an
> exported symbol.
>
> So you either didn't test this, or it depends upon custom
> kernel changes which you didn't mention.
>
> Either way I can't apply this, sorry
Yes, we need export the sysmbol for the test. Can we export the symbol?
or I can delete the route input test, which one do you prefer?
Thanks,
Shaohua
next prev parent reply other threads:[~2015-01-15 21:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 5:45 net_test_tools: add ipv6 support for kbench_mod Shaohua Li
2015-01-14 6:35 ` David Miller
2015-01-15 21:17 ` Shaohua Li [this message]
2015-01-15 23:08 ` David Miller
2015-01-22 22:12 ` Shaohua Li
2015-01-23 9:55 ` Daniel Borkmann
2015-01-23 15:58 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150115211737.GA2587066@devbig257.prn2.facebook.com \
--to=shli@fb.com \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.