Re: [PATCH] parse-ip: Add support for keystone platforms

[Denys Dmytriyenko <denys@ti.com>]

On Thu, Jan 15, 2015 at 10:33:20PM -0500, Nelson, Sam wrote:
> 
> 
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Thursday, January 15, 2015 10:06 PM
> > To: Nelson, Sam
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] parse-ip: Add support for keystone
> > platforms
> > 
> > On Thu, Jan 15, 2015 at 09:01:43PM -0500, Sam Nelson wrote:
> > > - Added separate script for keystone platforms
> > > - Script parses ip and sends to uart, picked up by BMC and display on LCD
> > screen
> > >
> > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > ---
> > >  .../recipes-tisdk/parse-ip/parse-ip.bb             |   12 ++++---
> > >  .../recipes-tisdk/parse-ip/parse-ip/init.keystone  |   37
> > ++++++++++++++++++++
> > >  2 files changed, 45 insertions(+), 4 deletions(-)
> > >  create mode 100644 meta-arago-distro/recipes-tisdk/parse-ip/parse-
> > ip/init.keystone
> > >
> > > diff --git a/meta-arago-distro/recipes-tisdk/parse-ip/parse-ip.bb b/meta-
> > arago-distro/recipes-tisdk/parse-ip/parse-ip.bb
> > > index f20db31..5353ac6 100644
> > > --- a/meta-arago-distro/recipes-tisdk/parse-ip/parse-ip.bb
> > > +++ b/meta-arago-distro/recipes-tisdk/parse-ip/parse-ip.bb
> > > @@ -2,23 +2,27 @@ DESCRIPTION = "Script to parse ip address during
> > boot and make it available to t
> > >  LICENSE = "BSD"
> > >  LIC_FILES_CHKSUM =
> > "file://init;beginline=3;endline=31;md5=fc4b04a33df6d892c9f4d4a9d92b94
> > 5e"
> > >
> > > -COMPATIBLE_MACHINE = "ti33x|ti43x"
> > > +COMPATIBLE_MACHINE = "ti33x|ti43x|keystone"
> > >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> > >
> > > -SRC_URI = "file://init"
> > > +SRC_URI = "file://init \
> > > +	   file://init.keystone"
> > 
> > I don't remember if SOC_FAMILY was added to file overrides, but have you
> > tried
> > placing your specific init under recipes-tisdk/parse-ip/parse-
> > ip/keystone/init?
> > 
> > That way you don't need to make changes to the recipe itself, it should pick
> > up your keystone-specific version of the file automatically.
> [Sam] Even if the file is put under: recipes-tisdk/parse-ip/parse- ip/keystone/init,
>  the recipe copies the specific init file:  see line below
> install -m 0755 ${WORKDIR}/init  > ${D}${sysconfdir}/init.d/parse-ip

Note that it's copied from WORKDIR, which will be populated with the correct file.


> which I had to  replace with 
> install -m 0755 ${WORKDIR}/${INITSCRIPT_FILENAME} ${D}${sysconfdir}/init.d/parse-ip
> 
> So it won't be automatically picked up. Still recipe change is needed.
> ( Unless you have a way to work around this).
> > 
> > 
> > > -PR = "r2"
> > > +PR = "r3"
> > >
> > >  S = "${WORKDIR}"
> > >
> > >  INITSCRIPT_NAME = "parse-ip"
> > >  INITSCRIPT_PARAMS = "defaults 98"
> > > +INITSCRIPT_FILENAME = "init"
> > > +
> > > +INITSCRIPT_FILENAME_keystone = "init.keystone"
> > >
> > >  inherit update-rc.d
> > >
> > >  do_install() {
> > >      install -d ${D}${sysconfdir}/init.d
> > > -    install -m 0755 ${WORKDIR}/init ${D}${sysconfdir}/init.d/parse-ip
> > > +    install -m 0755 ${WORKDIR}/${INITSCRIPT_FILENAME}
> > ${D}${sysconfdir}/init.d/parse-ip
> > >  }
> > >
> > >  FILES_${PN} = "${sysconfdir}"
> > > diff --git a/meta-arago-distro/recipes-tisdk/parse-ip/parse-ip/init.keystone
> > b/meta-arago-distro/recipes-tisdk/parse-ip/parse-ip/init.keystone
> > > new file mode 100644
> > > index 0000000..7ea199e
> > > --- /dev/null
> > > +++ b/meta-arago-distro/recipes-tisdk/parse-ip/parse-ip/init.keystone
> > > @@ -0,0 +1,37 @@
> > > +#*
> > > +#* Copyright (C) 2012-2014 Texas Instruments Incorporated -
> > http://www.ti.com/
> > > +#*
> > > +#*
> > > +#*  Redistribution and use in source and binary forms, with or without
> > > +#*  modification, are permitted provided that the following conditions
> > > +#*  are met:
> > > +#*
> > > +#*    Redistributions of source code must retain the above copyright
> > > +#*    notice, this list of conditions and the following disclaimer.
> > > +#*
> > > +#*    Redistributions in binary form must reproduce the above copyright
> > > +#*    notice, this list of conditions and the following disclaimer in the
> > > +#*    documentation and/or other materials provided with the
> > > +#*    distribution.
> > > +#*
> > > +#*    Neither the name of Texas Instruments Incorporated nor the names
> > of
> > > +#*    its contributors may be used to endorse or promote products derived
> > > +#*    from this software without specific prior written permission.
> > > +#*
> > > +
> > > +#! /bin/sh
> > > +
> > > +case "$1" in
> > > +    start )
> > > +        echo '#>>>>> LCD 12' > ipaddr
> > > +        echo 'IP Address:' >> ipaddr
> > > +        cat ipaddr
> > > +
> > > +        echo `ifconfig | grep 'inet addr:' | grep -v '127.0.0.1' | cut -d: -f2 | awk
> > '{print $1}'` > ipaddr
> > > +        cat ipaddr
> > > +
> > > +        sleep 1
> > > +    ;;
> > > +    stop )
> > > +        exit 0;;
> > > +esac
> > > --
> > > 1.7.9.5
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago