From: Jesper Nilsson <jesper.nilsson@axis.com>
To: David Howells <dhowells@redhat.com>
Cc: Jesper Nilsson <jespern@axis.com>,
"viro@ZenIV.linux.org.uk" <viro@ZenIV.linux.org.uk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-cris-kernel <linux-cris-kernel@axis.com>
Subject: Re: [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2]
Date: Fri, 16 Jan 2015 09:34:33 +0100 [thread overview]
Message-ID: <20150116083433.GZ26817@axis.com> (raw)
In-Reply-To: <20150113175753.29073.20788.stgit@warthog.procyon.org.uk>
On Tue, Jan 13, 2015 at 06:57:53PM +0100, David Howells wrote:
> Convert file->f_dentry->d_inode to file_inode() so as to get layered
> filesystems right.
>
> Found with: git grep '[.>]f_dentry'
Yes, compile works with this patch. Do you want me to take it through
the CRIS tree or do you have any other tree in mind?
> Signed-off-by: David Howells <dhowells@redhat.com>
In any case:
Reviewed-by: Jesper Nilsson <jesper.nilsson@axis.com>
> arch/cris/arch-v32/drivers/sync_serial.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/cris/arch-v32/drivers/sync_serial.c b/arch/cris/arch-v32/drivers/sync_serial.c
> index 08a313fc2241..f772068d9e79 100644
> --- a/arch/cris/arch-v32/drivers/sync_serial.c
> +++ b/arch/cris/arch-v32/drivers/sync_serial.c
> @@ -604,7 +604,7 @@ static ssize_t __sync_serial_read(struct file *file,
> struct timespec *ts)
> {
> unsigned long flags;
> - int dev = MINOR(file->f_dentry->d_inode->i_rdev);
> + int dev = MINOR(file_inode(file)->i_rdev);
> int avail;
> struct sync_port *port;
> unsigned char *start;
>
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2015-01-16 8:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 17:57 [PATCH] VFS: Convert file->f_dentry->d_inode to file_inode() [ver #2] David Howells
2015-01-16 8:34 ` Jesper Nilsson [this message]
2015-01-19 12:06 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150116083433.GZ26817@axis.com \
--to=jesper.nilsson@axis.com \
--cc=dhowells@redhat.com \
--cc=jespern@axis.com \
--cc=linux-cris-kernel@axis.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.