From: Tony Lindgren <tony@atomide.com>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: Benoit Cousson <bcousson@baylibre.com>,
Nishanth Menon <nm@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
Felipe Balbi <balbi@ti.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Thomas Gleixner <tglx@linutronix.de>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] ARM: OMAP: Work around hardcoded interrupts
Date: Sat, 17 Jan 2015 09:40:28 -0800 [thread overview]
Message-ID: <20150117174028.GU18552@atomide.com> (raw)
In-Reply-To: <1421490068-20385-1-git-send-email-marc.zyngier@arm.com>
* Marc Zyngier <marc.zyngier@arm.com> [150117 02:24]:
> Commit 9a1091ef0017 (irqchip: gic: Support hierarchy irq domain)
> changed the GIC driver to use a non-legacy IRQ domain on DT
> platforms. This patch assumes that DT-driven systems are getting
> all of their interrupts from device tree.
>
> Turns out that OMAP has quite a few hidden gems, and still uses
> hardcoded interrupts despite having fairly complete DTs.
>
> This patch attempts to work around these by offering a translation
> method that can be called directly from the hwmod code, if present.
> The same hack is sprinkled over PRCM and TWL.
>
> It isn't pretty, but it seems to do the job without having to add
> more hacks to the interrupt controller code.
>
> Tested on OMAP4 (Panda-ES) and OMAP5 (UEVM5432).
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> >From v1:
> - OMAP4 can either get the PRM interrupt from hwmod or from device tree.
> In the latter case, remove the xlate_irq method.
OK looks good to me. Let's wait for Nishanth to run his tests
one more time.
BTW, looks like we already have the omap4 prm interrupt in the
omap4.dtsi file but removing the legacy code would add the
"old DT with newer kernel" issues to the mixture.. So best
leave that for later clean up patches and keep this fix as is.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP: Work around hardcoded interrupts
Date: Sat, 17 Jan 2015 09:40:28 -0800 [thread overview]
Message-ID: <20150117174028.GU18552@atomide.com> (raw)
In-Reply-To: <1421490068-20385-1-git-send-email-marc.zyngier@arm.com>
* Marc Zyngier <marc.zyngier@arm.com> [150117 02:24]:
> Commit 9a1091ef0017 (irqchip: gic: Support hierarchy irq domain)
> changed the GIC driver to use a non-legacy IRQ domain on DT
> platforms. This patch assumes that DT-driven systems are getting
> all of their interrupts from device tree.
>
> Turns out that OMAP has quite a few hidden gems, and still uses
> hardcoded interrupts despite having fairly complete DTs.
>
> This patch attempts to work around these by offering a translation
> method that can be called directly from the hwmod code, if present.
> The same hack is sprinkled over PRCM and TWL.
>
> It isn't pretty, but it seems to do the job without having to add
> more hacks to the interrupt controller code.
>
> Tested on OMAP4 (Panda-ES) and OMAP5 (UEVM5432).
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> >From v1:
> - OMAP4 can either get the PRM interrupt from hwmod or from device tree.
> In the latter case, remove the xlate_irq method.
OK looks good to me. Let's wait for Nishanth to run his tests
one more time.
BTW, looks like we already have the omap4 prm interrupt in the
omap4.dtsi file but removing the legacy code would add the
"old DT with newer kernel" issues to the mixture.. So best
leave that for later clean up patches and keep this fix as is.
Regards,
Tony
next prev parent reply other threads:[~2015-01-17 17:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-17 10:21 [PATCH v2] ARM: OMAP: Work around hardcoded interrupts Marc Zyngier
2015-01-17 10:21 ` Marc Zyngier
2015-01-17 17:40 ` Tony Lindgren [this message]
2015-01-17 17:40 ` Tony Lindgren
2015-01-19 20:14 ` Nishanth Menon
2015-01-19 20:14 ` Nishanth Menon
2015-01-19 20:12 ` Tony Lindgren
2015-01-19 20:12 ` Tony Lindgren
2015-01-19 21:21 ` Tony Lindgren
2015-01-19 21:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150117174028.GU18552@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
--cc=tglx@linutronix.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.