All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mykola Golub <to.my.trociny@gmail.com>
To: ceph-devel <ceph-devel@vger.kernel.org>
Subject: mon: forwarding user commands
Date: Sun, 18 Jan 2015 11:28:16 +0200	[thread overview]
Message-ID: <20150118092815.GA2488@gmail.com> (raw)

Hi Ceph,

Right now, for not a monitor leader, if a received command is not
supported locally, but is supported by the leader, it is forwarded to
the leader.

For the recently added "ceph tell mon.x version" it gives a confusing
behavior: if the mon.x is not a leader and does not support "version"
command yet, but the leader does, the user will receive the version of
the leader, and can't be actually sure about a non leader version.

I have a patch that fixes this by checking if the received "version"
command is forwarded and returning the error in this case:

https://github.com/trociny/ceph/commit/98f835357e378b1c5f05b32ba90a8b8537ba1ad8

But may be we need a more general solution? We might face a similar
issue in future, when adding a new command, which is not expected to
be forwarded to the leader (like injectargs).

-- 
Mykola Golub

             reply	other threads:[~2015-01-18  9:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-18  9:28 Mykola Golub [this message]
2015-01-18 18:33 ` mon: forwarding user commands Sage Weil
2015-01-19  7:02   ` Mykola Golub
2015-01-19 14:57     ` Gregory Farnum
2015-01-19 15:17       ` Sage Weil
2015-01-27  8:31         ` Mykola Golub
2015-01-27 16:20           ` Sage Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150118092815.GA2488@gmail.com \
    --to=to.my.trociny@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.