From: Lee Jones <lee.jones@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Thierry Reding <thierry.reding@gmail.com>,
"linux-pwm@vger.kernel.org" <linux-pwm@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Imre Kaloz <kaloz@openwrt.org>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@googlemail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 3/7] gpio: mvebu: Add limited PWM support
Date: Sun, 18 Jan 2015 10:04:38 +0000 [thread overview]
Message-ID: <20150118100438.GC3574@x1> (raw)
In-Reply-To: <CACRpkda_guCTyivDB5z8jisxYvnsE-1vrvt+N_k1Kp_f+nhQFg@mail.gmail.com>
On Thu, 15 Jan 2015, Linus Walleij wrote:
> On Tue, Jan 13, 2015 at 3:42 AM, Andrew Lunn <andrew@lunn.ch> wrote:
>
> > So i thought about this some more. What would an MFD based solution
> > look like?
> >
> > First issue is backwards compatibility. There are currently around 90
> > .dts files using this gpio driver. I could imagine a few of these
> > being changed to make use of an MFD based driver to make us of the new
> > features, but the rest expect backwards compatibility.
>
> Good point.
>
> > I think the only sensible way to achieve this is that the gpio driver
> > keeps its existing binding.
>
> Yup.
>
> > This does not really describe the hardware. The hardware is more like:
> >
> > gpio: gpio {
> > compatible = "marvell,orion-gpio";
> > reg = <0xd0018100 0x40>;
> > ngpios = <32>;
> > gio-controller;
> > #gpio-cells = <2>;
> > interrupt-controller;
> > #interrupt-cells = <2>;
> > interrupts = <16>, <17>, <18>, <19>;
> > clocks = <&coreclk 0>;
> >
> > pwm: pwm {
> > compatible = "marvell,armada-pwm";
> > reg = <0xd00181c0 0x08>;
> > #pwm-cells = <2>;
> > clocks = <&coreclk 0>;
> > };
> > };
> >
> > but i don't think MFD supports that sort of structure?
>
> No it would have to be some custom DT code in the GPIO driver
> spawning the PWM platform device.
of_platform_populate()?
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-01-18 10:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 23:34 [PATCH 0/7] Add PWM support to mvebu gpio driver Andrew Lunn
2015-01-09 23:34 ` [PATCH 1/7] gpio: mvebu: checkpatch fixes Andrew Lunn
2015-01-14 13:04 ` Linus Walleij
2015-01-09 23:34 ` [PATCH 2/7] gpio: mvebu: Fix probe cleanup on error Andrew Lunn
2015-01-14 13:05 ` Linus Walleij
2015-01-09 23:34 ` [PATCH 3/7] gpio: mvebu: Add limited PWM support Andrew Lunn
2015-01-12 11:05 ` Imre Kaloz
2015-01-12 13:12 ` Andrew Lunn
2015-01-12 14:06 ` Linus Walleij
2015-01-12 15:07 ` Andrew Lunn
2015-01-13 2:42 ` Andrew Lunn
2015-01-15 9:52 ` Linus Walleij
2015-01-17 20:04 ` Andrew Lunn
2015-01-18 10:04 ` Lee Jones [this message]
2015-01-19 12:59 ` Thierry Reding
2015-01-20 10:52 ` Lee Jones
2015-01-19 13:01 ` Thierry Reding
2015-06-12 10:38 ` Thierry Reding
2015-01-09 23:34 ` [PATCH 4/7] DT: bindings: Extend mvebu gpio documentation with PWM Andrew Lunn
2015-01-09 23:34 ` [PATCH 5/7] mvebu: xp: Add pwm properties to .dtsi files Andrew Lunn
2015-01-09 23:34 ` [PATCH 6/7] arm: mvebu: Enable PWM in defconfig Andrew Lunn
2015-01-09 23:34 ` [PATCH 7/7] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan Andrew Lunn
2015-02-23 14:09 ` [PATCH 0/7] Add PWM support to mvebu gpio driver Gregory CLEMENT
2015-02-23 15:48 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118100438.GC3574@x1 \
--to=lee.jones@linaro.org \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=kaloz@openwrt.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sebastian.hesselbarth@googlemail.com \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.