From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path
Date: Sun, 18 Jan 2015 16:01:52 +0100 [thread overview]
Message-ID: <20150118150152.GI4275@free.fr> (raw)
In-Reply-To: <1421580900-15186-3-git-send-email-romain.naour@openwide.fr>
Romain, All,
On 2015-01-18 12:35 +0100, Romain Naour spake thusly:
> The recognized keywords are:
> (location path: "external:internal:none")
>
> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, some comments below...
> ---
> package/rpm/rpm.mk | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/rpm/rpm.mk b/package/rpm/rpm.mk
> index ce7189e..6725ca4 100644
> --- a/package/rpm/rpm.mk
> +++ b/package/rpm/rpm.mk
> @@ -34,14 +34,14 @@ ifeq ($(BR2_PACKAGE_PCRE),y)
... here ...
> RPM_DEPENDENCIES += pcre
> RPM_CONF_OPTS += --with-pcre=external
> else
> -RPM_CONF_OPTS += --with-pcre=no
> +RPM_CONF_OPTS += --with-pcre=none
> endif
>
> ifeq ($(BR2_PACKAGE_FILE),y)
... and here, we do rely on the dependant packages, without adding
sub-options to rpm to select them. I think we should do the same for
bzip2 and xz.
Regards,
Yann E. MORIN.
> RPM_DEPENDENCIES += file
> RPM_CONF_OPTS += --with-file=external
> else
> -RPM_CONF_OPTS += --with-file=no
> +RPM_CONF_OPTS += --with-file=none
> endif
>
> ifeq ($(BR2_PACKAGE_RPM_XZ_PAYLOADS),y)
> --
> 1.9.3
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-01-18 15:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 11:34 [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Romain Naour
2015-01-18 11:34 ` [Buildroot] [PATCH 2/3] package/rpm: use external xz library Romain Naour
2015-01-18 14:59 ` Yann E. MORIN
2015-01-18 18:57 ` Romain Naour
2015-01-18 11:35 ` [Buildroot] [PATCH 3/3] package/rpm: use 'none' for location path Romain Naour
2015-01-18 15:01 ` Yann E. MORIN [this message]
2015-01-18 14:21 ` [Buildroot] [PATCH 1/3] package/rpm: add gettext dependency Yann E. MORIN
2015-01-18 18:57 ` Romain Naour
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150118150152.GI4275@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.