From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YD5NM-0002Ug-F5 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 00:59:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YD5NJ-0002Xe-8S for qemu-devel@nongnu.org; Mon, 19 Jan 2015 00:59:48 -0500 Date: Mon, 19 Jan 2015 17:00:00 +1100 From: David Gibson Message-ID: <20150119060000.GA5297@voom.fritz.box> References: <1419337831-16552-1-git-send-email-mdroth@linux.vnet.ibm.com> <1419337831-16552-18-git-send-email-mdroth@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jE+K4o1MICf3EEet" Content-Disposition: inline In-Reply-To: <1419337831-16552-18-git-send-email-mdroth@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 17/17] spapr_pci: emit hotplug add/remove events during hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, agraf@suse.de, ncmike@ncultra.org, qemu-ppc@nongnu.org, tyreld@linux.vnet.ibm.com, bharata.rao@gmail.com, nfont@linux.vnet.ibm.com --jE+K4o1MICf3EEet Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 23, 2014 at 06:30:31AM -0600, Michael Roth wrote: > From: Tyrel Datwyler >=20 > This uses extension of existing EPOW interrupt/event mechanism > to notify userspace tools like librtas/drmgr to handle > in-guest configuration/cleanup operations in response to > device_add/device_del. >=20 > Userspace tools that don't implement this extension will need > to be run manually in response/advance of device_add/device_del, > respectively. >=20 > Signed-off-by: Tyrel Datwyler > Signed-off-by: Michael Roth > --- > hw/ppc/spapr_pci.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c > index 94e33b4..f17f984 100644 > --- a/hw/ppc/spapr_pci.c > +++ b/hw/ppc/spapr_pci.c > @@ -705,6 +705,9 @@ static void spapr_phb_hot_plug(HotplugHandler *plug_h= andler, > =20 > g_assert(drc); > spapr_device_hotplug_add(drc, phb, pdev); > + if (plugged_dev->hotplugged) { > + spapr_hotplug_req_add_event(drc); > + } > } > =20 > static void spapr_phb_hot_unplug(HotplugHandler *plug_handler, > @@ -722,6 +725,7 @@ static void spapr_phb_hot_unplug(HotplugHandler *plug= _handler, > } > =20 > spapr_device_hotplug_remove(drc, phb, pdev); > + spapr_hotplug_req_remove_event(drc); The event is sent after the "physical" remove. Is that correct? > } > =20 > static void spapr_phb_realize(DeviceState *dev, Error **errp) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --jE+K4o1MICf3EEet Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUvJ1gAAoJEGw4ysog2bOSItcP/2WPtV7VF+1kCTaMKL6kCAn+ ktaQmtaxH6zrddlmrocLlEmk/vk6u9JMH1huPgvuY4CI5R/3KK38vLX5AyZvtH1F 5SWdqgLqxiLK/7sgJQ74eSTxgAly8EZMsBUDFul7CHzm4jZDedjfUAM1ROXNxcVu 1qp8QuhE8JKw/GLRJY4+ufHpF+dNNWLN51eaoPB8L9ehIulfryOsaNZP6tWG3OjE 3Z+CPAfy4nrGvnmfgyuI+ADOG5odz3C5JWCvVVpyEshcbNGRQWWY/xIymbxjufN9 LHH5B2SdARK0yJXZKYcjYDwslVagGLWDYLuTTrKe8hUDK+v+HCe7FetK45Y6o8jX oIFoWfClC9MrD6SMr7l0n7QC3uXYHs7SNQEJbgnAbzczUWax1C4YAHwu7LroZZoA 2gdL5nUu6fOPHQE8C5esIMY5EueXZnQFbOHBpGyUZRNeCPfLBb451iSxYgbdjTQn Nrhqqud/lS+T79pvUua8nOSalt5CaD1y0qbcURtScF9YP5BUDv+ttzRKU8jN/cUp B/V2Q+SG84os6igUCb4er2DM7hB+ETBneiZx4+BmuEXnKCMFWhRazCU4wESMSmR7 pDzWmFkzwQAAxB3R8rtIf2oRM9E6A9ID9uds7S4HyYofBQxs0uZquckopEpvNmx5 2cHmNN4+WO0rCpXNnzqX =V7mu -----END PGP SIGNATURE----- --jE+K4o1MICf3EEet--