From: Christoph Hellwig <hch@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: module: fix module_refcount() return when running in a module exit routine
Date: Mon, 19 Jan 2015 00:28:15 -0800 [thread overview]
Message-ID: <20150119082815.GA26697@infradead.org> (raw)
In-Reply-To: <878ugzco8c.fsf@rustcorp.com.au>
On Mon, Jan 19, 2015 at 04:21:15PM +1030, Rusty Russell wrote:
> The first one I think should be eliminated, and the second one is simply
> an assertion before calling module_put() (which should probably be
> eliminated). The others are just printing information.
FYI, I've got a pathcset to eliminate the use of module_refcount in
SCSI, which was a horrible hack to start with, but it needs a little more
clarification / work, so I'd prefer to do it for 3.20. Bart has a fix
that eliminates it for 3.19, which piles aother bandaid over the bandaid
that introduced the use module_refcount, and James doesn't seem to like
it.
next prev parent reply other threads:[~2015-01-19 8:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 16:55 module: fix module_refcount() return when running in a module exit routine James Bottomley
2015-01-18 23:37 ` Rusty Russell
2015-01-18 23:37 ` Rusty Russell
2015-01-19 5:18 ` Masami Hiramatsu
2015-01-19 5:51 ` Rusty Russell
2015-01-19 8:28 ` Christoph Hellwig [this message]
2015-01-19 16:07 ` James Bottomley
2015-01-19 16:08 ` James Bottomley
2015-01-20 0:45 ` Rusty Russell
2015-01-20 2:17 ` Masami Hiramatsu
2015-01-20 17:23 ` James Bottomley
2015-01-21 5:30 ` Rusty Russell
2015-01-22 16:50 ` Christoph Hellwig
2015-01-22 17:02 ` James Bottomley
2015-01-23 2:54 ` Rusty Russell
2015-01-23 13:17 ` Christoph Hellwig
2015-01-23 18:42 ` James Bottomley
2015-01-23 23:35 ` Rusty Russell
2015-01-26 17:16 ` Christoph Hellwig
2015-01-28 9:23 ` Bart Van Assche
2015-01-28 21:45 ` James Bottomley
2015-01-29 12:16 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119082815.GA26697@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.