From: Cyril Hrubis <chrubis@suse.cz>
To: Zeng Linggang <zenglg.jy@cn.fujitsu.com>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH v2 02/12] smack_file_access.sh: Cleanup
Date: Mon, 19 Jan 2015 16:51:56 +0100 [thread overview]
Message-ID: <20150119155156.GA30735@rei> (raw)
In-Reply-To: <1419327221-28508-2-git-send-email-zenglg.jy@cn.fujitsu.com>
Hi!
> -if [ ! -d "$Where" ]; then
> - if [ -e "$Where" ]; then
> - echo "Test directory \"$Where\" exists but is not a directory."
> - exit 1
> - fi
> - mkdir -m 777 "$Where"
> - if [ ! -d "$Where" ]; then
> - echo "Test directory \"$Where\" can not be created."
> - exit 1
> - fi
> -fi
> +tst_tmpdir
> +TST_CLEANUP=cleanup
> +
> +chmod 777 $(pwd)
Hmm, we do chmod 777 for the TMPDIR in the C test library. I guess that
it will be better to move the chmod to test.sh and omit it here.
The rest of the patchset looks good to me.
--
Cyril Hrubis
chrubis@suse.cz
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2015-01-19 15:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-23 9:33 [LTP] [PATCH v2 01/12] smack_common.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 02/12] smack_file_access.sh: Cleanup Zeng Linggang
2015-01-19 15:51 ` Cyril Hrubis [this message]
[not found] ` <1421742761-10192-1-git-send-email-zenglg.jy@cn.fujitsu.com>
[not found] ` <1421742761-10192-9-git-send-email-zenglg.jy@cn.fujitsu.com>
2015-01-20 13:34 ` [LTP] [PATCH v3 09/12] smack_set_load.sh: Cleanup Cyril Hrubis
[not found] ` <1421742761-10192-12-git-send-email-zenglg.jy@cn.fujitsu.com>
2015-01-20 13:41 ` [LTP] [PATCH v3 12/12] smack_set_socket_labels.c: Cleanup Cyril Hrubis
[not found] ` <1421809918-21785-1-git-send-email-zenglg.jy@cn.fujitsu.com>
2015-01-27 15:28 ` [LTP] [PATCH] smack_set_socket_labels.c: Add `parse_opts' and so on Cyril Hrubis
[not found] ` <1421742761-10192-8-git-send-email-zenglg.jy@cn.fujitsu.com>
[not found] ` <1421810019.19850.1.camel@G08JYZSD130126.localdomain>
2015-01-21 11:56 ` [LTP] [PATCH v3 08/12] smack_set_doi.sh: Cleanup Cyril Hrubis
2014-12-23 9:33 ` [LTP] [PATCH v2 03/12] smack_set_ambient.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 04/12] smack_set_cipso.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 05/12] smack_set_current.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 06/12] smack_set_direct.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 07/12] smack_set_doi.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 08/12] smack_set_load.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 09/12] smack_set_netlabel.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 10/12] smack_set_onlycap.sh: Cleanup Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 11/12] smack: Rename 'notroot.c' to 'smack_notroot.c' Zeng Linggang
2014-12-23 9:33 ` [LTP] [PATCH v2 12/12] smack_set_socket_labels.c: Cleanup Zeng Linggang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150119155156.GA30735@rei \
--to=chrubis@suse.cz \
--cc=ltp-list@lists.sourceforge.net \
--cc=zenglg.jy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.