From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 20 Jan 2015 10:29:19 +0000 Subject: [PATCH v3 2/3] mfd: lubbock_io: add lubbock_io board In-Reply-To: <87ppaah9k5.fsf@free.fr> References: <1421406010-14851-1-git-send-email-robert.jarzmik@free.fr> <1421406010-14851-2-git-send-email-robert.jarzmik@free.fr> <20150119091705.GG21886@x1> <87ppaah9k5.fsf@free.fr> Message-ID: <20150120102919.GP5767@x1> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 19 Jan 2015, Robert Jarzmik wrote: > Lee Jones writes: > > On Fri, 16 Jan 2015, Robert Jarzmik wrote: [...] > >> + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > > > platform_get_irq()? > No. I need the flags. Where are they used? [...] > >> + if (ret) { > >> + dev_err(&pdev->dev, "Couldn't request main irq : ret = %d\n", > >> + ret); > > > > I'm not keen on this type of formatting. Besides the system will > > print out the returned error on failure. > Well, it will print -EINVAL or -ENODEV. When I'll receive an request on the > driver with -ENODEV, how will I know it will come from this request_irq() or > another part of the code ... Well I can remove it if you want, but I think it's > an error. I'm not asking you to remove the entire message, just the junk at the end. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v3 2/3] mfd: lubbock_io: add lubbock_io board Date: Tue, 20 Jan 2015 10:29:19 +0000 Message-ID: <20150120102919.GP5767@x1> References: <1421406010-14851-1-git-send-email-robert.jarzmik@free.fr> <1421406010-14851-2-git-send-email-robert.jarzmik@free.fr> <20150119091705.GG21886@x1> <87ppaah9k5.fsf@free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <87ppaah9k5.fsf-GANU6spQydw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Robert Jarzmik Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Daniel Mack , Haojian Zhuang , Samuel Ortiz , Arnd Bergmann , Dmitry Eremin-Solenikov , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Mon, 19 Jan 2015, Robert Jarzmik wrote: > Lee Jones writes: > > On Fri, 16 Jan 2015, Robert Jarzmik wrote: [...] > >> + res =3D platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > > > platform_get_irq()? > No. I need the flags. Where are they used? [...] > >> + if (ret) { > >> + dev_err(&pdev->dev, "Couldn't request main irq : ret =3D %d\n", > >> + ret); > > > > I'm not keen on this type of formatting. Besides the system will > > print out the returned error on failure. > Well, it will print -EINVAL or -ENODEV. When I'll receive an request = on the > driver with -ENODEV, how will I know it will come from this request_i= rq() or > another part of the code ... Well I can remove it if you want, but I = think it's > an error. I'm not asking you to remove the entire message, just the junk at the end. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753099AbbATK32 (ORCPT ); Tue, 20 Jan 2015 05:29:28 -0500 Received: from mail-ie0-f171.google.com ([209.85.223.171]:54212 "EHLO mail-ie0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752361AbbATK30 (ORCPT ); Tue, 20 Jan 2015 05:29:26 -0500 Date: Tue, 20 Jan 2015 10:29:19 +0000 From: Lee Jones To: Robert Jarzmik Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Daniel Mack , Haojian Zhuang , Samuel Ortiz , Arnd Bergmann , Dmitry Eremin-Solenikov , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 2/3] mfd: lubbock_io: add lubbock_io board Message-ID: <20150120102919.GP5767@x1> References: <1421406010-14851-1-git-send-email-robert.jarzmik@free.fr> <1421406010-14851-2-git-send-email-robert.jarzmik@free.fr> <20150119091705.GG21886@x1> <87ppaah9k5.fsf@free.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87ppaah9k5.fsf@free.fr> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Jan 2015, Robert Jarzmik wrote: > Lee Jones writes: > > On Fri, 16 Jan 2015, Robert Jarzmik wrote: [...] > >> + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > > > platform_get_irq()? > No. I need the flags. Where are they used? [...] > >> + if (ret) { > >> + dev_err(&pdev->dev, "Couldn't request main irq : ret = %d\n", > >> + ret); > > > > I'm not keen on this type of formatting. Besides the system will > > print out the returned error on failure. > Well, it will print -EINVAL or -ENODEV. When I'll receive an request on the > driver with -ENODEV, how will I know it will come from this request_irq() or > another part of the code ... Well I can remove it if you want, but I think it's > an error. I'm not asking you to remove the entire message, just the junk at the end. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog