Re: [Linaro-uefi] [PATCH] firmware: efi: remove unneeded guid unparse

[Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

On Tue, Jan 20, 2015 at 04:20:10PM +0000, Ard Biesheuvel wrote:
> On 20 January 2015 at 16:12, Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> > There is no reason to translate guid number to string here.
> > So remove it in order to not do unneeded work.
> >
> > Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> >  drivers/firmware/efi/efi.c | 5 -----
> >  1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> > index 9035c1b..f6be017 100644
> > --- a/drivers/firmware/efi/efi.c
> > +++ b/drivers/firmware/efi/efi.c
> > @@ -272,15 +272,10 @@ static __init int match_config_table(efi_guid_t *guid,
> >                                      unsigned long table,
> >                                      efi_config_table_type_t *table_types)
> >  {
> > -       u8 str[EFI_VARIABLE_GUID_LEN + 1];
> >         int i;
> >
> >         if (table_types) {
> > -               efi_guid_unparse(guid, str);
> > -
> >                 for (i = 0; efi_guidcmp(table_types[i].guid, NULL_GUID); i++) {
> > -                       efi_guid_unparse(&table_types[i].guid, str);
> > -
> >                         if (!efi_guidcmp(*guid, table_types[i].guid)) {
> >                                 *(table_types[i].ptr) = table;
> >                                 pr_cont(" %s=0x%lx ",

Doh! Left the unparses in after I removed the debug printouts :|
Thanks for spotting.

Acked-by: Leif Lindholm <leif.lindholm-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

> Acked-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

/
    Leif