Re: [PATCH] Fix of coding style

[Theodore Ts'o <tytso@mit.edu>]

On Tue, Jan 20, 2015 at 01:37:31PM +0100, Jiri Slaby wrote:
> On 01/20/2015, 12:59 PM, Jan Mrazek wrote:
> > - init_timer changed to setup_timer
> > - multiline strings changed to single line (so it can be greped)
> > - other small conding style changes
> > 
> > Signed-off-by: Jan Mrazek <email@honzamrazek.cz>
> 
> Note that one hunk does not apply cleanly here:
>  Hunk #35 succeeded at 3581 with fuzz 1 (offset 16 lines).
> 
> What tree did you use as a base? Care to rebase?
> 
> Reviewed-by: Jiri Slaby <jslaby@suse.cz>
> 
> (There is a nit: leaving up to the maintainers if they insist on
> separating the setup_timer change or not :).)

Yes, please separate it out; in general I'm not terribly excited about
these sorts of massive cleanup patches, because it breaks patches that
other people send me.  (I'll also note that many of the multi-line
separations happened people running checkpatch sent me cleanup
patches; so the fact that I'm now getting a cleanup patch to reverse
this also predisposes me to not be very receptive to these sorts of
cleanups.  I will generally ask developers to send me checkpatch clean
patches, but I'm less enthusiastic about cleanup patches for their own
sake.)

That being said, the setup_timer change is small, and less disruptive,
so separating that out is good because I will likely accept the
setup_timer change, but probably not the multi-line string change,
since regardless of what you base it against, there is a very good
chance it won't apply against the ext4 development tree --- and if it
does, it will likely break other patches that people send me.

Cheers,

						- Ted