From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Turquette Subject: Re: [PATCH 1/2] clk: exynos5420: Add IDs for clocks used in DISP1 power domain Date: Tue, 20 Jan 2015 09:54:02 -0800 Message-ID: <20150120175402.22722.84342@quantum> References: <1421750127-22536-1-git-send-email-javier.martinez@collabora.co.uk> <1421750127-22536-2-git-send-email-javier.martinez@collabora.co.uk> <54BE6050.1090205@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Return-path: Received: from mail-pd0-f172.google.com ([209.85.192.172]:51874 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752547AbbATRyN convert rfc822-to-8bit (ORCPT ); Tue, 20 Jan 2015 12:54:13 -0500 Received: by mail-pd0-f172.google.com with SMTP id v10so22955666pde.3 for ; Tue, 20 Jan 2015 09:54:12 -0800 (PST) In-Reply-To: <54BE6050.1090205@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sylwester Nawrocki , Javier Martinez Canillas , Kukjin Kim Cc: Tomasz Figa , Rahul Sharma , Arun Kumar K , Doug Anderson , Olof Johansson , Marek Szyprowski , Tobias Jakobi , Andrzej Hajda , Krzysztof Kozlowski , Kevin Hilman , Joonyoung Shim , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Quoting Sylwester Nawrocki (2015-01-20 06:04:00) > Hi, > > On 20/01/15 11:35, Javier Martinez Canillas wrote: > > When a power domain is powered off on Exynos5420 SoC, the input clocks of > > the devices attached to this power domain are re-parented to oscclk and > > restored to the original parent after powering on the power domain. > > > > So a reference to the input and parent clocks for the devices attached to > > a power domain are needed to be able to do the re-parenting. The DISP1 pd > > includes modules which uses the following clocks: > > > > ACLK_200_DISP1 (MIXER and HDMILINK) > > ACLK_300_DISP1 (FIMD1) > > ACLK_400_DISP1 (Internal Buses) > > > > Each of these clocks are generated as the output of a clock mux so add an > > ID for all of these clock muxes and their parents to be referenced in the > > DISP1 power domain device node. > > > > Signed-off-by: Javier Martinez Canillas > > The patch looks OK to me, I'm fine with it being merged via Kukjin's tree > due to the dts dependencies (including other pending dts patches touching > the arch/arm/boot/dts/exynos5420.dtsi file). > I think we need also Mike ACK for that, I could also queue the patch for > the clk tree and create a topic branch, but merging both patches via > arm-soc seems a more sane option in this case. > > Acked-by: Sylwester Nawrocki Acked-by: Michael Turquette > > -- > Thanks, > Sylwester > From mboxrd@z Thu Jan 1 00:00:00 1970 From: mturquette@linaro.org (Mike Turquette) Date: Tue, 20 Jan 2015 09:54:02 -0800 Subject: [PATCH 1/2] clk: exynos5420: Add IDs for clocks used in DISP1 power domain In-Reply-To: <54BE6050.1090205@samsung.com> References: <1421750127-22536-1-git-send-email-javier.martinez@collabora.co.uk> <1421750127-22536-2-git-send-email-javier.martinez@collabora.co.uk> <54BE6050.1090205@samsung.com> Message-ID: <20150120175402.22722.84342@quantum> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Quoting Sylwester Nawrocki (2015-01-20 06:04:00) > Hi, > > On 20/01/15 11:35, Javier Martinez Canillas wrote: > > When a power domain is powered off on Exynos5420 SoC, the input clocks of > > the devices attached to this power domain are re-parented to oscclk and > > restored to the original parent after powering on the power domain. > > > > So a reference to the input and parent clocks for the devices attached to > > a power domain are needed to be able to do the re-parenting. The DISP1 pd > > includes modules which uses the following clocks: > > > > ACLK_200_DISP1 (MIXER and HDMILINK) > > ACLK_300_DISP1 (FIMD1) > > ACLK_400_DISP1 (Internal Buses) > > > > Each of these clocks are generated as the output of a clock mux so add an > > ID for all of these clock muxes and their parents to be referenced in the > > DISP1 power domain device node. > > > > Signed-off-by: Javier Martinez Canillas > > The patch looks OK to me, I'm fine with it being merged via Kukjin's tree > due to the dts dependencies (including other pending dts patches touching > the arch/arm/boot/dts/exynos5420.dtsi file). > I think we need also Mike ACK for that, I could also queue the patch for > the clk tree and create a topic branch, but merging both patches via > arm-soc seems a more sane option in this case. > > Acked-by: Sylwester Nawrocki Acked-by: Michael Turquette > > -- > Thanks, > Sylwester >