From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arcturus.aphlor.org (arcturus.ipv6.aphlor.org [IPv6:2a03:9800:10:4a::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 0B95F1A02CB for ; Wed, 21 Jan 2015 09:49:30 +1100 (AEDT) Date: Tue, 20 Jan 2015 16:40:33 -0500 From: Dave Jones To: Michael Ellerman Subject: Re: [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default Message-ID: <20150120214033.GA30240@codemonkey.org.uk> References: <1421144560-15901-1-git-send-email-khandual@linux.vnet.ibm.com> <1421144560-15901-7-git-send-email-khandual@linux.vnet.ibm.com> <54B5384F.9010805@osg.samsung.com> <1421192671.10748.4.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1421192671.10748.4.camel@ellerman.id.au> Cc: mikey@neuling.org, linux-kernel@vger.kernel.org, Shuah Khan , anton@samba.org, linuxppc-dev@lists.ozlabs.org, Anshuman Khandual List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Jan 14, 2015 at 10:44:31AM +1100, Michael Ellerman wrote: > > Also, I would like to see the test results reports using > > kselftest.h - it can be separate patch in the interest of > > getting tests in. > > Sorry but kselftest.h doesn't do anything useful for us. > > We have existing test reporting that uses the subunit protocol. > > I'm happy to convert that to TAP, or some other well defined output format, but > not to something ad-hoc like kselftest.h currently provides. Something TAP-alike would also help reduce some of the spew from tests that are going to fail. eg, running execveat tests on a kernel that doesn't implement that syscall currently spews around 20 lines of [FAIL]. Adding something to the beginning of the test to set plan() accordingly if it detects -ENOSYS could make that output a little cleaner. That other projects (like jenkins, bug trackers etc) could consume the output of the test runs would be a nice bonus. I only recently started looking at kselftests and was surprised at the amount of variance we have in the way of printing 'Ok' '[OK]' 'ok...' etc. Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbbATVk5 (ORCPT ); Tue, 20 Jan 2015 16:40:57 -0500 Received: from arcturus.aphlor.org ([188.246.204.175]:40518 "EHLO arcturus.aphlor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750801AbbATVk4 (ORCPT ); Tue, 20 Jan 2015 16:40:56 -0500 Date: Tue, 20 Jan 2015 16:40:33 -0500 From: Dave Jones To: Michael Ellerman Cc: Shuah Khan , Anshuman Khandual , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, anton@samba.org, mikey@neuling.org Subject: Re: [PATCH V2 06/12] selftests, powerpc: Add test for system wide DSCR default Message-ID: <20150120214033.GA30240@codemonkey.org.uk> Mail-Followup-To: Dave Jones , Michael Ellerman , Shuah Khan , Anshuman Khandual , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org, anton@samba.org, mikey@neuling.org References: <1421144560-15901-1-git-send-email-khandual@linux.vnet.ibm.com> <1421144560-15901-7-git-send-email-khandual@linux.vnet.ibm.com> <54B5384F.9010805@osg.samsung.com> <1421192671.10748.4.camel@ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1421192671.10748.4.camel@ellerman.id.au> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -2.9 (--) X-Spam-Report: Spam report generated by SpamAssassin on "arcturus.aphlor.org" Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Authenticated-User: davej@codemonkey.org.uk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 14, 2015 at 10:44:31AM +1100, Michael Ellerman wrote: > > Also, I would like to see the test results reports using > > kselftest.h - it can be separate patch in the interest of > > getting tests in. > > Sorry but kselftest.h doesn't do anything useful for us. > > We have existing test reporting that uses the subunit protocol. > > I'm happy to convert that to TAP, or some other well defined output format, but > not to something ad-hoc like kselftest.h currently provides. Something TAP-alike would also help reduce some of the spew from tests that are going to fail. eg, running execveat tests on a kernel that doesn't implement that syscall currently spews around 20 lines of [FAIL]. Adding something to the beginning of the test to set plan() accordingly if it detects -ENOSYS could make that output a little cleaner. That other projects (like jenkins, bug trackers etc) could consume the output of the test runs would be a nice bonus. I only recently started looking at kselftests and was surprised at the amount of variance we have in the way of printing 'Ok' '[OK]' 'ok...' etc. Dave