From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from slow1-d.mail.gandi.net (slow1-d.mail.gandi.net [217.70.178.86]) by lists.ozlabs.org (Postfix) with ESMTP id 53F781A0C32 for ; Wed, 21 Jan 2015 10:02:10 +1100 (AEDT) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by slow1-d.mail.gandi.net (Postfix) with ESMTP id 8906A47ECD2 for ; Wed, 21 Jan 2015 00:02:07 +0100 (CET) Date: Tue, 20 Jan 2015 15:01:50 -0800 From: josh@joshtriplett.org To: Kim Phillips Subject: Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds Message-ID: <20150120230150.GA14475@cloud> References: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> Cc: Konstantin Khlebnikov , Rik van Riel , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jens Axboe , Minchan Kim , Al Viro , Johannes Weiner , Sasha Levin , Andrew Morton , linuxppc-dev@lists.ozlabs.org, Joonsoo Kim List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: > It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on > ppc. Fix building the generic kernel_map_pages() implementation in > this case: > > LD init/built-in.o > mm/built-in.o: In function `free_pages_prepare': > mm/page_alloc.c:770: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `prep_new_page': > mm/page_alloc.c:933: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `map_pages': > mm/compaction.c:61: undefined reference to `.kernel_map_pages' > make: *** [vmlinux] Error 1 > > Signed-off-by: Kim Phillips > --- > mm/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Makefile b/mm/Makefile > index 4bf586e..2956467 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -46,6 +46,7 @@ obj-$(CONFIG_SLOB) += slob.o > obj-$(CONFIG_MMU_NOTIFIER) += mmu_notifier.o > obj-$(CONFIG_KSM) += ksm.o > obj-$(CONFIG_PAGE_POISONING) += debug-pagealloc.o > +obj-$(CONFIG_DEBUG_PAGEALLOC) += debug-pagealloc.o Does it work correctly to list the same object file twice? Doesn't seem like it would. Shouldn't this do something like the following instead: ifneq ($(CONFIG_DEBUG_PAGEALLOC)$(CONFIG_PAGE_POISONING),) obj-y += debug-pagealloc.o endif ? > obj-$(CONFIG_SLAB) += slab.o > obj-$(CONFIG_SLUB) += slub.o > obj-$(CONFIG_KMEMCHECK) += kmemcheck.o > -- > 2.2.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com (mail-pd0-f178.google.com [209.85.192.178]) by kanga.kvack.org (Postfix) with ESMTP id A8FFC6B0032 for ; Tue, 20 Jan 2015 18:02:01 -0500 (EST) Received: by mail-pd0-f178.google.com with SMTP id y10so6237452pdj.9 for ; Tue, 20 Jan 2015 15:02:01 -0800 (PST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net. [2001:4b98:c:538::195]) by mx.google.com with ESMTPS id nj1si5835048pbc.249.2015.01.20.15.01.58 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 20 Jan 2015 15:02:00 -0800 (PST) Date: Tue, 20 Jan 2015 15:01:50 -0800 From: josh@joshtriplett.org Subject: Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds Message-ID: <20150120230150.GA14475@cloud> References: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> Sender: owner-linux-mm@kvack.org List-ID: To: Kim Phillips Cc: Andrew Morton , Johannes Weiner , Minchan Kim , Joonsoo Kim , Rik van Riel , Sasha Levin , Al Viro , Konstantin Khlebnikov , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: > It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on > ppc. Fix building the generic kernel_map_pages() implementation in > this case: > > LD init/built-in.o > mm/built-in.o: In function `free_pages_prepare': > mm/page_alloc.c:770: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `prep_new_page': > mm/page_alloc.c:933: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `map_pages': > mm/compaction.c:61: undefined reference to `.kernel_map_pages' > make: *** [vmlinux] Error 1 > > Signed-off-by: Kim Phillips > --- > mm/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Makefile b/mm/Makefile > index 4bf586e..2956467 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -46,6 +46,7 @@ obj-$(CONFIG_SLOB) += slob.o > obj-$(CONFIG_MMU_NOTIFIER) += mmu_notifier.o > obj-$(CONFIG_KSM) += ksm.o > obj-$(CONFIG_PAGE_POISONING) += debug-pagealloc.o > +obj-$(CONFIG_DEBUG_PAGEALLOC) += debug-pagealloc.o Does it work correctly to list the same object file twice? Doesn't seem like it would. Shouldn't this do something like the following instead: ifneq ($(CONFIG_DEBUG_PAGEALLOC)$(CONFIG_PAGE_POISONING),) obj-y += debug-pagealloc.o endif ? > obj-$(CONFIG_SLAB) += slab.o > obj-$(CONFIG_SLUB) += slub.o > obj-$(CONFIG_KMEMCHECK) += kmemcheck.o > -- > 2.2.2 > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752118AbbATXB7 (ORCPT ); Tue, 20 Jan 2015 18:01:59 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50222 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751479AbbATXB6 (ORCPT ); Tue, 20 Jan 2015 18:01:58 -0500 Date: Tue, 20 Jan 2015 15:01:50 -0800 From: josh@joshtriplett.org To: Kim Phillips Cc: Andrew Morton , Johannes Weiner , Minchan Kim , Joonsoo Kim , Rik van Riel , Sasha Levin , Al Viro , Konstantin Khlebnikov , Jens Axboe , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/2] mm: fix undefined reference to `.kernel_map_pages' on PPC builds Message-ID: <20150120230150.GA14475@cloud> References: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150120140200.aa7ba0eb28d95e456972e178@freescale.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 20, 2015 at 02:02:00PM -0600, Kim Phillips wrote: > It's possible to configure DEBUG_PAGEALLOC without PAGE_POISONING on > ppc. Fix building the generic kernel_map_pages() implementation in > this case: > > LD init/built-in.o > mm/built-in.o: In function `free_pages_prepare': > mm/page_alloc.c:770: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `prep_new_page': > mm/page_alloc.c:933: undefined reference to `.kernel_map_pages' > mm/built-in.o: In function `map_pages': > mm/compaction.c:61: undefined reference to `.kernel_map_pages' > make: *** [vmlinux] Error 1 > > Signed-off-by: Kim Phillips > --- > mm/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/Makefile b/mm/Makefile > index 4bf586e..2956467 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -46,6 +46,7 @@ obj-$(CONFIG_SLOB) += slob.o > obj-$(CONFIG_MMU_NOTIFIER) += mmu_notifier.o > obj-$(CONFIG_KSM) += ksm.o > obj-$(CONFIG_PAGE_POISONING) += debug-pagealloc.o > +obj-$(CONFIG_DEBUG_PAGEALLOC) += debug-pagealloc.o Does it work correctly to list the same object file twice? Doesn't seem like it would. Shouldn't this do something like the following instead: ifneq ($(CONFIG_DEBUG_PAGEALLOC)$(CONFIG_PAGE_POISONING),) obj-y += debug-pagealloc.o endif ? > obj-$(CONFIG_SLAB) += slab.o > obj-$(CONFIG_SLUB) += slub.o > obj-$(CONFIG_KMEMCHECK) += kmemcheck.o > -- > 2.2.2 >