From: kbuild test robot <fengguang.wu@intel.com>
To: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Cc: kbuild-all@01.org, Ulf Hansson <ulf.hansson@linaro.org>,
Andy Green <andy.green@linaro.org>,
Tetsuya Takinishi <t.takinishi@jp.fujitsu.com>,
Chris Ball <chris@printf.net>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings
Date: Wed, 21 Jan 2015 19:19:45 +0800 [thread overview]
Message-ID: <20150121111944.GA229257@athens> (raw)
In-Reply-To: <201501211941.NPuKVMjL%fengguang.wu@intel.com>
drivers/mmc/host/sdhci_f_sdh30.c:143:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 144
PTR_ERR should access the value just tested by IS_ERR
Semantic patch information:
There can be false positives in the patch case, where it is the call
IS_ERR that is wrong.
Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
CC: Vincent Yang <vincent.yang.fujitsu@gmail.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
sdhci_f_sdh30.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/mmc/host/sdhci_f_sdh30.c
+++ b/drivers/mmc/host/sdhci_f_sdh30.c
@@ -141,7 +141,7 @@ static int sdhci_f_sdh30_probe(struct pl
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
host->ioaddr = devm_ioremap_resource(&pdev->dev, res);
if (IS_ERR(host->ioaddr)) {
- ret = PTR_ERR(host);
+ ret = PTR_ERR(host->ioaddr);
goto err;
}
next parent reply other threads:[~2015-01-21 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201501211941.NPuKVMjL%fengguang.wu@intel.com>
2015-01-21 11:19 ` kbuild test robot [this message]
2015-01-21 11:37 ` [PATCH] mmc: sdhci: host: fix odd_ptr_err.cocci warnings Ulf Hansson
2015-01-21 11:45 ` Vincent Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150121111944.GA229257@athens \
--to=fengguang.wu@intel.com \
--cc=andy.green@linaro.org \
--cc=chris@printf.net \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=t.takinishi@jp.fujitsu.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.yang.fujitsu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.