All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: "Wang, Zhihong" <zhihong.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH 0/4] DPDK memcpy optimization
Date: Wed, 21 Jan 2015 11:40:22 +0000	[thread overview]
Message-ID: <20150121114022.GA10756@bricha3-MOBL3> (raw)
In-Reply-To: <F60F360A2500CD45ACDB1D700268892D0E75F664-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>

On Wed, Jan 21, 2015 at 03:44:23AM +0000, Wang, Zhihong wrote:
 
> Neil, Bruce,
> 
> Some data first.
> 
> Sandy Bridge without AVX2:
> 1. original w/ 10 constant memcpy: 2'25" 
> 2. patch w/ 12 constant memcpy: 2'41" 
> 3. patch w/ 63 constant memcpy: 9'41" 
> 
> Haswell with AVX2:
> 1. original w/ 10 constant memcpy: 1'57" 
> 2. patch w/ 12 constant memcpy: 1'56" 
> 3. patch w/ 63 constant memcpy: 3'16" 
> 
> Also, to address Bruce's question, we have to reduce test case to cut down compile time. Because we use:
> 1. intrinsics instead of assembly for better flexibility and can utilize more compiler optimization 
> 2. complex function body for better performance 
> 3. inlining 
> This increases compile time.
> But I think it'd be okay to do that as long as we can select a fair set of test points.
> 
> It'd be great if you could give some suggestion, say, 12 points.
> 
> Zhihong (John)
> 
Hi Zhihong,

Just for comparison I've done a clean dpdk compile on my SNB system this morning.
Using parallel make (which is pretty normal I suspect), I get the following
numbers:
 real    0m52.549s
 user    0m36.034s
 sys     0m10.014s

So total compile time is 52 seconds.

Running a make uninstall and then make install again with "-j 1", provides the 
following numbers:

 real    0m32.751s
 user    0m16.041s
 sys     0m7.946s

Obviously, caching effects are being completely ignored by the this unscientific
study (rerunning the first test again gives a 13-second time), but the upshot
is that the compile time for DPDK right now is well under a minute in the normal
case. Adding in a new file that, in the best case, takes two minutes to compile
is going to increase our compile time many times over. 

Regards,
/Bruce

  parent reply	other threads:[~2015-01-21 11:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19  1:53 [PATCH 0/4] DPDK memcpy optimization zhihong.wang-ral2JQCrhuEAvxtiuMwx3w
     [not found] ` <1421632414-10027-1-git-send-email-zhihong.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-19  1:53   ` [PATCH 1/4] app/test: Disabled VTA for memcpy test in app/test/Makefile zhihong.wang-ral2JQCrhuEAvxtiuMwx3w
2015-01-19  1:53   ` [PATCH 2/4] app/test: Removed unnecessary test cases in test_memcpy.c zhihong.wang-ral2JQCrhuEAvxtiuMwx3w
2015-01-19  1:53   ` [PATCH 3/4] app/test: Extended test coverage in test_memcpy_perf.c zhihong.wang-ral2JQCrhuEAvxtiuMwx3w
2015-01-19  1:53   ` [PATCH 4/4] lib/librte_eal: Optimized memcpy in arch/x86/rte_memcpy.h for both SSE and AVX platforms zhihong.wang-ral2JQCrhuEAvxtiuMwx3w
     [not found]     ` <1421632414-10027-5-git-send-email-zhihong.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-20 17:15       ` Stephen Hemminger
2015-01-20 19:16         ` Neil Horman
     [not found]           ` <20150120191624.GJ18449-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-01-21  3:18             ` Wang, Zhihong
2015-01-25 20:02         ` Jim Thompson
2015-01-26 14:43       ` Wodkowski, PawelX
     [not found]         ` <F6F2A6264E145F47A18AB6DF8E87425D12B8C8E2-kPTMFJFq+rFP9JyJpTNKArfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-27  5:12           ` Wang, Zhihong
2015-01-19 13:02   ` [PATCH 0/4] DPDK memcpy optimization Neil Horman
     [not found]     ` <20150119130221.GB21790-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-01-20  3:01       ` Wang, Zhihong
     [not found]         ` <F60F360A2500CD45ACDB1D700268892D0E75EFFE-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-20 15:11           ` Neil Horman
     [not found]             ` <20150120151118.GD18449-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-01-20 16:14               ` Bruce Richardson
2015-01-21  3:44                 ` Wang, Zhihong
     [not found]                   ` <F60F360A2500CD45ACDB1D700268892D0E75F664-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-21 11:40                     ` Bruce Richardson [this message]
2015-01-21 12:02                     ` Ananyev, Konstantin
     [not found]                       ` <2601191342CEEE43887BDE71AB977258213DE922-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-21 12:38                         ` Neil Horman
     [not found]                           ` <20150121123801.GB18515-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-01-23  3:26                             ` Wang, Zhihong
2015-01-21 12:36                     ` Marc Sune
     [not found]                       ` <54BF9D59.7070104-kpkqNMk1I7M@public.gmane.org>
2015-01-21 13:02                         ` Bruce Richardson
2015-01-21 13:21                           ` Marc Sune
     [not found]                             ` <54BFA7D5.7020106-kpkqNMk1I7M@public.gmane.org>
2015-01-21 13:26                               ` Bruce Richardson
2015-01-21 19:49                                 ` Stephen Hemminger
2015-01-21 20:54                                   ` Neil Horman
     [not found]                                     ` <20150121205404.GB32617-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org>
2015-01-21 21:25                                       ` Jim Thompson
     [not found]                                         ` <53D2253B-DE20-486E-ADF0-DA02AAB1EF35-jiyf0hk6h8BBDgjK7y7TUQ@public.gmane.org>
2015-01-22  0:53                                           ` Stephen Hemminger
2015-01-22  9:06                                           ` Luke Gorrie
     [not found]                                             ` <CAA2XHbcG4kZzOiMibQhjRxjg_aCJpZ4djgXbQf=FECgZropbCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-22 13:29                                               ` Jay Rolette
     [not found]                                                 ` <CADNuJVrzFzT6WOWM8W13xvv8ad5b2GMO8C12EFYRb1vQZGyTBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-01-22 18:27                                                   ` Luke Gorrie
2015-01-22 19:36                                                     ` Jay Rolette
2015-01-22 18:21                                       ` EDMISON, Kelvin (Kelvin)
     [not found]                                         ` <D0E6A94E.41FE0%kelvin.edmison-cfy2TCaE7SFv+uJa97DSA9BPR1lH4CV8@public.gmane.org>
2015-01-27  8:22                                           ` Wang, Zhihong
     [not found]                                             ` <F60F360A2500CD45ACDB1D700268892D0E761378-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-28 21:48                                               ` EDMISON, Kelvin (Kelvin)
     [not found]                                                 ` <D0EE79A7.42BCB%kelvin.edmison-cfy2TCaE7SFv+uJa97DSA9BPR1lH4CV8@public.gmane.org>
2015-01-29  1:53                                                   ` Wang, Zhihong
2015-01-23  6:52                                 ` Wang, Zhihong
     [not found]                                   ` <F60F360A2500CD45ACDB1D700268892D0E760527-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-26 18:29                                     ` Ananyev, Konstantin
     [not found]                                       ` <2601191342CEEE43887BDE71AB977258213DFA32-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-27  1:42                                         ` Wang, Zhihong
     [not found]                                           ` <F60F360A2500CD45ACDB1D700268892D0E760F8B-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-27 11:30                                             ` Ananyev, Konstantin
     [not found]                                               ` <2601191342CEEE43887BDE71AB977258213DFC4D-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-27 12:19                                                 ` Ananyev, Konstantin
     [not found]                                                   ` <2601191342CEEE43887BDE71AB977258213DFDEE-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-01-28  2:06                                                     ` Wang, Zhihong
2015-01-29  3:42   ` Fu, JingguoX
2015-01-25 14:50 ` [dpdk-dev] " Luke Gorrie
2015-01-26  1:30   ` Wang, Zhihong
2015-01-26  8:03     ` Luke Gorrie
2015-01-27  7:19       ` Wang, Zhihong
2015-01-27 13:57         ` Luke Gorrie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121114022.GA10756@bricha3-MOBL3 \
    --to=bruce.richardson-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=zhihong.wang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.