All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Dave Chinner <david@fromorbit.com>
Cc: jack@suse.cz, xfs@oss.sgi.com
Subject: Re: [PATCH 0/3] xfs: buffer types need to be set
Date: Wed, 21 Jan 2015 17:07:57 +0100	[thread overview]
Message-ID: <20150121160757.GA20357@quack.suse.cz> (raw)
In-Reply-To: <1421800780-26008-1-git-send-email-david@fromorbit.com>

   Hi Dave,

On Wed 21-01-15 11:39:37, Dave Chinner wrote:
> These three patches detect and fix the issues you reported with log
> recovery finding buffers with a format type of zero. The type of
> zero (XFS_BLFT_UNKNOWN_BUF) is only valid for buffers that have
> been cancelled (i.e. invalidated or marked stale as they have been
> freed), so the series adds asserts to ensure these conditions are
> met during transaction commit. Hence we shouldn't ever get new code
> that fails to set the buffer type getting through testing.
> 
> The last two patches fix the cases that running xfstests uncovered
> where we don't set the buffer type appropriately. There may be more,
> but doing this much made my head hurt and xfstests is clean, so it's
> as much as I'm going to do right now. Can you test it and see if it
> runs clean (with CONFIG_XFS_WARN=y or CONFIG_XFS_DEBUG=y) on your
> test setup?
  Thanks for a quick response with patches. My test round has finished and
the new assertion didn't trigger so things look fine. I've also provided a
test kernel to the guy seeing these issues in the wild but there it took
days / weeks to trigger so I wouldn't wait for it...

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2015-01-21 16:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21  0:39 [PATCH 0/3] xfs: buffer types need to be set Dave Chinner
2015-01-21  0:39 ` [PATCH 1/3] xfs: ensure buffer types are set correctly Dave Chinner
2015-01-21 22:05   ` Brian Foster
2015-01-21  0:39 ` [PATCH 2/3] xfs: inode unlink does not set AGI buffer type Dave Chinner
2015-01-21 22:05   ` Brian Foster
2015-01-21  0:39 ` [PATCH 3/3] xfs: set buf types when converting extent formats Dave Chinner
2015-01-21 22:06   ` Brian Foster
2015-01-21  2:34 ` [PATCH 4/3] xfs: set superblock buffer type correctly Dave Chinner
2015-01-21 22:06   ` Brian Foster
2015-01-21 16:07 ` Jan Kara [this message]
2015-01-21 17:11   ` [PATCH 0/3] xfs: buffer types need to be set Jan Kara
2015-01-21 21:12   ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121160757.GA20357@quack.suse.cz \
    --to=jack@suse.cz \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.