All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lin Kassem <linsara1@gmail.com>
To: devel@driverdev.osuosl.org
Cc: forest@alittletooquiet.net, gregkh@linuxfoundation.org,
	tvboxspy@gmail.com, linux-kernel@vger.kernel.org
Subject: [PATCH] staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
Date: Wed, 21 Jan 2015 18:44:58 +0200	[thread overview]
Message-ID: <20150121164458.GA10302@lin-535U4C> (raw)

This patch fixes the following checkpatch.pl warning:
fix Prefer ether_addr_copy() over memcpy() 
if the Ethernet addresses are __aligned(2)

Pahole showed that the 2 structs are aligned to u16

struct ieee80211_hdr {
	__le16                     frame_control;        /*     0     2 */
	__le16                     duration_id;          /*     2     2 */
	u8                         addr1[6];             /*     4     6 */
	u8                         addr2[6];             /*    10     6 */
	u8                         addr3[6];             /*    16     6 */
	__le16                     seq_ctrl;             /*    22     2 */
	u8                         addr4[6];             /*    24     6 */

	/* size: 30, cachelines: 1, members: 7 */
	/* last cacheline: 30 bytes */
};

struct vnt_mic_hdr {
	u8                         id;                   /*     0     1 */
	u8                         tx_priority;          /*     1     1 */
	u8                         mic_addr2[6];         /*     2     6 */
	u8                         ccmp_pn[6];           /*     8     6 */
	__be16                     payload_len;          /*    14     2 */
	__be16                     hlen;                 /*    16     2 */
	__le16                     frame_control;        /*    18     2 */
	u8                         addr1[6];             /*    20     6 */
	u8                         addr2[6];             /*    26     6 */
	u8                         addr3[6];             /*    32     6 */
	__le16                     seq_ctrl;             /*    38     2 */
	u8                         addr4[6];             /*    40     6 */
	u16                        packing;              /*    46     2 */

	/* size: 48, cachelines: 1, members: 13 */
	/* last cacheline: 48 bytes */
};

Signed-off-by: Lin Kassem <linsara1@gmail.com>
---
 drivers/staging/vt6656/rxtx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index bb6a4d4..c202147 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -749,7 +749,7 @@ static void vnt_fill_txkey(struct vnt_usb_send_context *tx_context,
 		else
 			mic_hdr->hlen = cpu_to_be16(22);
 
-		memcpy(mic_hdr->addr1, hdr->addr1, ETH_ALEN);
+		ether_addr_copy(mic_hdr->addr1, hdr->addr1);
 		memcpy(mic_hdr->addr2, hdr->addr2, ETH_ALEN);
 		memcpy(mic_hdr->addr3, hdr->addr3, ETH_ALEN);
 
-- 
1.7.9.5


             reply	other threads:[~2015-01-21 14:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-21 16:44 Lin Kassem [this message]
2015-01-21 15:55 ` [PATCH] staging: vt6656: fix Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Joe Perches
  -- strict thread matches above, loose matches on Subject: below --
2015-01-21 11:08 Heba Aamer
2015-01-23  0:09 ` Aya Mahfouz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150121164458.GA10302@lin-535U4C \
    --to=linsara1@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tvboxspy@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.