From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 21 Jan 2015 19:02:15 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:43139 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008667AbbAUSCNpzwD7 (ORCPT ); Wed, 21 Jan 2015 19:02:13 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 7B93C8186675; Wed, 21 Jan 2015 18:02:04 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 21 Jan 2015 18:02:07 +0000 Received: from localhost (192.168.159.136) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Wed, 21 Jan 2015 18:02:03 +0000 Date: Wed, 21 Jan 2015 10:02:00 -0800 From: Paul Burton To: David Daney CC: Markos Chandras , , "Maciej W. Rozycki" , Subject: Re: [PATCH] MIPS: kernel: cps-vec: Replace "addi" with "addiu" Message-ID: <20150121180200.GC15278@NP-P-BURTON> References: <1421854030-28929-1-git-send-email-markos.chandras@imgtec.com> <54BFE91F.7050906@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <54BFE91F.7050906@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.159.136] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 45418 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: paul.burton@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Wed, Jan 21, 2015 at 09:59:59AM -0800, David Daney wrote: > On 01/21/2015 07:27 AM, Markos Chandras wrote: > >The "addi" instruction will trap on overflows which is not something > >we need in this code, so we replace that with "addiu". > > > >Link: http://www.linux-mips.org/archives/linux-mips/2015-01/msg00430.html > >Cc: Maciej W. Rozycki > >Cc: # v3.15+ > >Cc: Paul Burton > >Signed-off-by: Markos Chandras > > Acked-by: David Daney > > Same comment about the stable thing. Is it needed for anything other than > follow-on MIPS r6 Patches? In both this & the MSA asmmacro.h cases, the additions should never cause overflow. So I agree, backporting to stable seems like overkill. Paul > > >--- > >Moving this out of the R6 patchset as requested by Maciej > >--- > > arch/mips/kernel/cps-vec.S | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:43139 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27008667AbbAUSCNpzwD7 (ORCPT ); Wed, 21 Jan 2015 19:02:13 +0100 Date: Wed, 21 Jan 2015 10:02:00 -0800 From: Paul Burton Subject: Re: [PATCH] MIPS: kernel: cps-vec: Replace "addi" with "addiu" Message-ID: <20150121180200.GC15278@NP-P-BURTON> References: <1421854030-28929-1-git-send-email-markos.chandras@imgtec.com> <54BFE91F.7050906@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <54BFE91F.7050906@gmail.com> Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: David Daney Cc: Markos Chandras , linux-mips@linux-mips.org, "Maciej W. Rozycki" , stable@vger.kernel.org Message-ID: <20150121180200.VNCOxNeoUZAY2DlOaSK5Nuy4UBTyBtr3MqCeK9bVoQw@z> On Wed, Jan 21, 2015 at 09:59:59AM -0800, David Daney wrote: > On 01/21/2015 07:27 AM, Markos Chandras wrote: > >The "addi" instruction will trap on overflows which is not something > >we need in this code, so we replace that with "addiu". > > > >Link: http://www.linux-mips.org/archives/linux-mips/2015-01/msg00430.html > >Cc: Maciej W. Rozycki > >Cc: # v3.15+ > >Cc: Paul Burton > >Signed-off-by: Markos Chandras > > Acked-by: David Daney > > Same comment about the stable thing. Is it needed for anything other than > follow-on MIPS r6 Patches? In both this & the MSA asmmacro.h cases, the additions should never cause overflow. So I agree, backporting to stable seems like overkill. Paul > > >--- > >Moving this out of the R6 patchset as requested by Maciej > >--- > > arch/mips/kernel/cps-vec.S | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > [...]